Created attachment 22095 [details] [review] Bug 11086 : Fixing some grammatical mistakes in member-flags and tools-home To test before the patch is applied notice that on the member-flags page it says "upload patron images in batch or one at a time" After the patch it should say "upload patron images in a batch or one at a time" Try also for tools-home We applied the patch, however at '/cgi-bin/koha/members/member-flags.pl?member=' the text of the line has not changed. However, it has changed as expected at '/cgi-bin/koha/tools/tools-home.pl'. Unable to sign off. We found that the second change was actually applied to the Help documentation. A follow up is required to apply the change to the database. Created attachment 22124 [details] Bug 11086 : Follow up, editing the database files also These changes are only for a new install, I decided it wasn't safe to change it for an update. It would overwrite any local translations people had made. Created attachment 22148 [details] [review] Bug 11086 : Fixing some grammatical mistakes in member-flags and tools-home To test before the patch is applied notice that on the member-flags page it says "upload patron images in batch or one at a time" After the patch it should say "upload patron images in a batch or one at a time" Try also for tools-home Created attachment 22149 [details] [review] Bug 11086 : Fixing some grammatical mistakes in member-flags and tools-home To test before the patch is applied notice that on the member-flags page it says "upload patron images in batch or one at a time" After the patch it should say "upload patron images in a batch or one at a time" Try also for tools-home Signed-off-by: David Noe <drnoe@bywatersolutions.com> During the process of teaching David Noe I inadvertently labeled the second patch with the wrong title. I will fix that up in the morning. -Brendan Created attachment 22452 [details] [review] [PASSED QA] Bug 11086 : Fixing some grammatical mistakes in member-flags and tools-home To test before the patch is applied notice that on the member-flags page it says "upload patron images in batch or one at a time" After the patch it should say "upload patron images in a batch or one at a time" Try also for tools-home Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> String change, only affecting templates. Created attachment 22453 [details] [review] [PASSED QA] Bug 11086 : Follow up, editing the database files also To test before the patch is applied notice that on the member-flags page it says "upload patron images in batch or one at a time" After the patch it should say "upload patron images in a batch or one at a time" Try also for tools-home Signed-off-by: David Noe <drnoe@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Changes permission description in en and untranslated installer files. Pushed to master. Thanks, Chris! This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Chris! |
Under Koha Tools Patron Images the description currently reads: Upload patron images in batch or one at a time Sentence should be changed for proper English grammar and for clarity sake the line could be changed to read: Upload patron images in a batch or one at a time