Summary: | Hide duplicate patron button if logged in user lacks CAN_user_borrowers permission | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | dcook, edward.m.veal, gmcharlt, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11097 - Hide duplicate patron button if logged in user lacks CAN_user_borrowers permission
Bug 11097 - Hide duplicate patron button if logged in user lacks CAN_user_borrowers permission [SIGN-OFF]Bug 11097 - Hide duplicate patron button if logged in user lacks CAN_user_borrowers permission Bug 11097 - Hide duplicate patron button if logged in user lacks CAN_user_borrowers permission |
Description
Owen Leonard
2013-10-21 21:35:00 UTC
Created attachment 22198 [details] [review] Bug 11097 - Hide duplicate patron button if logged in user lacks CAN_user_borrowers permission The "duplicate" button on the circ/patron toolbar should not appear if the logged in user lacks permission to edit patron records. This patch wraps the button in the required logic. To test, open a patron record in circulation or patrons and view as a staff client user who both has and doesn't have CAN_user_borrowers permission. The button should be shown and not shown accordingly. Created attachment 22252 [details] [review] Bug 11097 - Hide duplicate patron button if logged in user lacks CAN_user_borrowers permission The "duplicate" button on the circ/patron toolbar should not appear if the logged in user lacks permission to edit patron records. This patch wraps the button in the required logic. To test, open a patron record in circulation or patrons and view as a staff client user who both has and doesn't have CAN_user_borrowers permission. The button should be shown and not shown accordingly. Signed-off-by: David Cook <dcook@prosentient.com.au> I was only able to open a patron record in circulation, but it works as described. Created attachment 22254 [details] [review] [SIGN-OFF]Bug 11097 - Hide duplicate patron button if logged in user lacks CAN_user_borrowers permission The "duplicate" button on the circ/patron toolbar should not appear if the logged in user lacks permission to edit patron records. This patch wraps the button in the required logic. To test, open a patron record in circulation or patrons and view as a staff client user who both has and doesn't have CAN_user_borrowers permission. The button should be shown and not shown accordingly. Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> Created attachment 22261 [details] [review] Bug 11097 - Hide duplicate patron button if logged in user lacks CAN_user_borrowers permission The "duplicate" button on the circ/patron toolbar should not appear if the logged in user lacks permission to edit patron records. This patch wraps the button in the required logic. To test, open a patron record in circulation or patrons and view as a staff client user who both has and doesn't have CAN_user_borrowers permission. The button should be shown and not shown accordingly. Signed-off-by: Ed Veal <ed.veal@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Note: The "Change password" button (2 lines above) is contained in a test on the borrower permission. The test is done twice. Pushed to master. Thanks, Owen! This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Owen! |