| Summary: | label - opac - places on facets not easily css selectable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Rachel <r.dustin> |
| Component: | OPAC | Assignee: | Liz Rea <liz> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, liz, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 11312 | ||
| Attachments: |
Adding span to Topics
bug 11105 created topics span in opac bug 11105 created places span in opac [SIGNED OFF] Bug 11105: created places span in opac Bug 11105: created places span in opac |
||
|
Description
Rachel
2013-10-21 22:12:55 UTC
Created attachment 22221 [details] [review] Adding span to Topics This patch adds "<span id="topics-span"> Topics</span>" whereas other patches in this batch do something like this: <span id="facet-Itemtypes"> Item types </span> I think the "facet-XXX" pattern is better since it is more descriptive. It's redundant to give an id to your span which includes the word "span." Thanks for the patch--I hope you can submit a follow-up. Owen, I'll fix this one up, maintaining Rachel's authorship. Liz Created attachment 22892 [details] [review] bug 11105 created topics span in opac To test: Verify topics in the facets is wrapped in a span. Created attachment 22893 [details] [review] bug 11105 created places span in opac To test: Verify places in the facets is wrapped in a span. Created attachment 23119 [details] [review] [SIGNED OFF] Bug 11105: created places span in opac To test: Verify places in the facets is wrapped in a span. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template change only, works as expected. Created attachment 23190 [details] [review] Bug 11105: created places span in opac To test: Verify places in the facets is wrapped in a span. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template change only, works as expected. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I think we would like to have an id for each facets, I will add a new report for that. The patch will modify prog/bootstrap and intranet interfaces. Pushed to master. Thanks, Rachel! This patch has been pushed to 3.14.x, will be in 3.14.1 This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Rachel! |