Bug 11105

Summary: label - opac - places on facets not easily css selectable
Product: Koha Reporter: Rachel <r.dustin>
Component: OPACAssignee: Liz Rea <liz>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, gmcharlt, jonathan.druart, liz, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 11312    
Attachments: Adding span to Topics
bug 11105 created topics span in opac
bug 11105 created places span in opac
[SIGNED OFF] Bug 11105: created places span in opac
Bug 11105: created places span in opac

Description Rachel 2013-10-21 22:12:55 UTC
label - staff client - topics on facets not easily css selectable
Comment 1 Rachel 2013-10-21 22:53:45 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-10-21 23:31:05 UTC
This patch adds "<span id="topics-span"> Topics</span>" whereas other patches in this batch do something like this:

<span id="facet-Itemtypes"> Item types </span>

I think the "facet-XXX" pattern is better since it is more descriptive. It's redundant to give an id to your span which includes the word "span."

Thanks for the patch--I hope you can submit a follow-up.
Comment 3 Liz Rea 2013-11-13 03:31:19 UTC
Owen,
I'll fix this one up, maintaining Rachel's authorship.

Liz
Comment 4 Liz Rea 2013-11-13 03:47:27 UTC Comment hidden (obsolete)
Comment 5 Liz Rea 2013-11-13 03:51:51 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2013-11-24 20:48:52 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2013-11-27 15:18:39 UTC
Created attachment 23190 [details] [review]
Bug 11105: created places span in opac

To test:
Verify places in the facets is wrapped in a span.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Template change only, works as expected.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Jonathan Druart 2013-11-27 15:20:10 UTC
I think we would like to have an id for each facets, I will add a new report for that.

The patch will modify prog/bootstrap and intranet interfaces.
Comment 9 Galen Charlton 2013-11-27 17:57:04 UTC
Pushed to master.  Thanks, Rachel!
Comment 10 Fridolin Somers 2013-12-13 13:56:10 UTC
This patch has been pushed to 3.14.x, will be in 3.14.1
Comment 11 Tomás Cohen Arazi 2013-12-23 15:19:52 UTC
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Rachel!