Summary: | Right to left text in facets + facet count = mixed text | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, gmcharlt, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Right-to-left parenthesis mixup
Bug 11117: Fix text mixed in facets where RTL text + facet count showed [SIGNED-OFF] Bug 11117: Fix text mixed in facets where RTL text + facet count showed Bug 11117: Fix text mixed in facets where RTL text + facet count showed [SIGNED-OFF] Bug 11117: Fix text mixed in facets where RTL text + facet count showed [PASSED QA] Bug 11117: Fix text mixed in facets where RTL text + facet count showed |
Created attachment 27552 [details] [review] Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Created attachment 27553 [details] [review] [SIGNED-OFF] Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. Also checked with Arabic translation, OPAC bootstrap, prog and ccsr. Tested with arabic records. No koha-qa errors. Created attachment 27554 [details] [review] Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Created attachment 27722 [details] [review] [SIGNED-OFF] Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Still work as described. Checked in arabic with arabic records. No koha-qa errors Created attachment 27752 [details] [review] [PASSED QA] Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Still work as described. Checked in arabic with arabic records. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Confirmed bug and that the patch fixes it, tested in staff, prog, ccsr and bootstrap. Pushed to master. Thanks, Tomás! |
Created attachment 22294 [details] Right-to-left parenthesis mixup Steps to reproduce: - Have facets to show some right to left text (for example ص) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot.