Bug 11124

Summary: The staff benchmark script does not work with sql administrator account
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, gitbot, gmcharlt, kyle
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 11124: The staff benchmark script does not work with sql administrator account
Bug 11124: The staff benchmark script does not work with sql administrator account
Bug 11124: QA Follow-up resolving a warning and three typos
Bug 11124: QA Follow-up adding optional dependency HTTPD::Bench::ApacheBench
Bug 11124: The staff benchmark script does not work with sql administrator account
Bug 11124: QA Follow-up resolving a warning and three typos
Bug 11124: QA Follow-up adding optional dependency HTTPD::Bench::ApacheBench

Description Jonathan Druart 2013-10-23 14:48:00 UTC

    
Comment 1 Jonathan Druart 2013-10-23 14:52:25 UTC Comment hidden (obsolete)
Comment 2 I'm just a bot 2013-10-30 07:56:37 UTC
Patch applied cleanly, go forth and signoff
Comment 3 Marcel de Rooy 2013-12-06 09:57:47 UTC Comment hidden (obsolete)
Comment 4 Marcel de Rooy 2013-12-06 10:24:35 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2013-12-06 10:25:03 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall (khall) 2013-12-13 18:52:49 UTC
Created attachment 23536 [details] [review]
Bug 11124: The staff benchmark script does not work with sql administrator account

On step 6 (at least), the circulation and return page redirect to the
select branch page and nothing is done.

The script should die if the user used is the sql administrator account.

Test plan:
Suppose that the sql admin account is root/root and koha/koha a superlibrarian account.

1/
perl misc/load_testing/benchmark_staff.pl --steps=6
--url=http://admin.koha.local/cgi-bin/koha/
--password="koha" --user="koha"
should produce:
  ...
  Step 6
  ...

2/
perl misc/load_testing/benchmark_staff.pl --steps=1
--url=http://admin.koha.local/cgi-bin/koha/
--password="root" --user="root"
should produce:
Authentication successful
You cannot use the database administrator account to launch this script

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Kyle M Hall (khall) 2013-12-13 18:52:57 UTC
Created attachment 23537 [details] [review]
Bug 11124: QA Follow-up resolving a warning and three typos

Resolves warning on uninitialized author in split on line 128.
Just adds the same behavior for title on line 129 for completeness.
Fixes typo on occurrences and two other minor typos.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Kyle M Hall (khall) 2013-12-13 18:53:06 UTC
Created attachment 23538 [details] [review]
Bug 11124: QA Follow-up adding optional dependency HTTPD::Bench::ApacheBench

This dependency is used in load testing (misc/load_testing/*)

Test plan:
Check if you see the dependency listed on About/Perl modules.
Verify if the version information is correct.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Galen Charlton 2013-12-13 20:00:07 UTC
Pushed to master.  Thanks, Jonathan!
Comment 10 Fridolin Somers 2013-12-24 13:21:53 UTC
Patches pushed to 3.14.x, will be in 3.14.2