Summary: | PostgreSQL schema contains syntax errors | ||
---|---|---|---|
Product: | Koha | Reporter: | Dan Scott <dan> |
Component: | Database | Assignee: | Galen Charlton <gmcharlt> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 7365 | ||
Attachments: |
Fixes syntax errors in PostgreSQL db schema
Bug 11155: remove old PostgreSQL schema and MARC framework scripts Bug 11155: remove old PostgreSQL schema and MARC framework scripts Bug 11155: remove old PostgreSQL schema and MARC framework scripts |
Hi Dan, I am marking this WONTFIX, because we currently do not maintain the PostgresSQL db schema and it's outdated. To my knowledge Koha can currently not be used with PostgresSQL, but it might be possible sometime in the future, as we have started using DBIX::Class. Okay. Would you entertain a patch that removes the PostgreSQL cruft, then, so that people like me don't waste our time in the future? (In reply to Dan Scott from comment #2) > Okay. Would you entertain a patch that removes the PostgreSQL cruft, then, > so that people like me don't waste our time in the future? Yes, we will. Note that the general idea is that in the next release, the schema will be initialized from the DBIC schema classes, not big SQL scripts as is the status quo. Created attachment 23500 [details] [review] Bug 11155: remove old PostgreSQL schema and MARC framework scripts This patch removes the legacy Pg schema and MARC framework scripts as they're out of date. They will be replaced by use of DBIx::Class to deploy the schema. Loading the sample data and settings will be accomplished either by making the current scripts in installer/data/mysql DBMS-independent (or, at least, able to be processed by both MySQL and Pg), converting them to flat text files and writing code to load them, or a combination of the two approaches. To test: [1] Verify that installer/data/Pg is removed. There is some code in C4::Installer that refers to that directory, but it cannot be reached through normal means. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 23767 [details] [review] Bug 11155: remove old PostgreSQL schema and MARC framework scripts This patch removes the legacy Pg schema and MARC framework scripts as they're out of date. They will be replaced by use of DBIx::Class to deploy the schema. Loading the sample data and settings will be accomplished either by making the current scripts in installer/data/mysql DBMS-independent (or, at least, able to be processed by both MySQL and Pg), converting them to flat text files and writing code to load them, or a combination of the two approaches. To test: [1] Verify that installer/data/Pg is removed. There is some code in C4::Installer that refers to that directory, but it cannot be reached through normal means. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 23778 [details] [review] Bug 11155: remove old PostgreSQL schema and MARC framework scripts This patch removes the legacy Pg schema and MARC framework scripts as they're out of date. They will be replaced by use of DBIx::Class to deploy the schema. Loading the sample data and settings will be accomplished either by making the current scripts in installer/data/mysql DBMS-independent (or, at least, able to be processed by both MySQL and Pg), converting them to flat text files and writing code to load them, or a combination of the two approaches. To test: [1] Verify that installer/data/Pg is removed. There is some code in C4::Installer that refers to that directory, but it cannot be reached through normal means. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Patch pushed to 3.14.x, will be in 3.14.2. |
Created attachment 22507 [details] Fixes syntax errors in PostgreSQL db schema installer/data/Pg/kohastructure.sql contains two syntax errors: * "mediumtext" is not a valid data type for PostgreSQL * "branch_transfer_limits_pkey" defines the primary key twice, which causes an error for PostgreSQL