| Summary: | The basket group is not displayed on the supplier list page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 11171: Display basket group name on the supplier list page
[SIGNED-OFF] Bug 11171: Display basket group name on the supplier list page Bug 11171: FIX a javascript error [PASSED QA] Bug 11171: Display basket group name on the supplier list page [PASSED QA] Bug 11171: FIX a javascript error |
||
|
Description
Jonathan Druart
2013-10-30 14:50:39 UTC
Created attachment 22598 [details] [review] Bug 11171: Display basket group name on the supplier list page Test plan: search supplier and verify the basket group column is filled. Created attachment 22936 [details] [review] [SIGNED-OFF] Bug 11171: Display basket group name on the supplier list page Test plan: search supplier and verify the basket group column is filled. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I am sorry, but with this patch we have a Javascript error on the page: TypeError: a.aoColumns[c] is undefined http://localhost:8080/intranet-tmpl/lib/jquery/jquery.js Line 3 Created attachment 23130 [details] [review] Bug 11171: FIX a javascript error The previous patch adds an error on booksellers.pl: TypeError: a.aoColumns[c] is undefined It was caused by the add of the new column. The aoColumns DT parameter should manage it. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 23148 [details] [review] [PASSED QA] Bug 11171: Display basket group name on the supplier list page Test plan: search supplier and verify the basket group column is filled. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Works as described. Created attachment 23149 [details] [review] [PASSED QA] Bug 11171: FIX a javascript error The previous patch adds an error on booksellers.pl: TypeError: a.aoColumns[c] is undefined It was caused by the add of the new column. The aoColumns DT parameter should manage it. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Pushed to master. Thanks, Jonathan! Those patches has been pushed to 3.14.x, will be in 3.14.1 |