Bug 11174

Summary:	Wrong parameter 'valuec' in opac-authoritiessearchresultlist
Product:	Koha	Reporter:	Zeno Tajoli <ztajoli>
Component:	OPAC	Assignee:	Zeno Tajoli <ztajoli>
Status:	CLOSED FIXED	QA Contact:	Testopia <testopia>
Severity:	trivial
Priority:	P5 - low	CC:	fridolin.somers, gmcharlt, m.de.rooy, tomascohen
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	String patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Changes for opac-authoritiessearchresultlist templates BUG 11174 wrong parameter 'valuec' BUG 11174 wrong paramter 'valuec'

Description Zeno Tajoli 2013-10-30 18:11:38 UTC

In the template opac-authoritiessearchresultlist are dinamic written
link with 5xx heading.

But in the link is used a wrong 'valuec' parameter instead of 'value'.

It is present in prog and in / bootstrap template opac-authoritiessearchresultlist.tt

In prog it is at line 62
In bootstrap it is at line 88

Comment 1 Zeno Tajoli 2013-10-30 18:52:44 UTC Comment hidden (obsolete)

Created attachment 22613 [details] [review]
Changes for opac-authoritiessearchresultlist templates

Patch for prog and bootstrap

Comment 2 Zeno Tajoli 2013-10-30 19:13:18 UTC

Test plan:

1)Insert an authority record with a 5xx field  (on MARC21 or UNIMARC)
2)Index the record
3)Seek the record
4)Clik one of the link build from the 5xx field, the link doesn't work
5)Apply the patch
6)Close the browser
7)Open the opac and select the english interface
8)Redo the search 
9)Now the link works
10)To use the patch in others languages you need to regenerate the templates.


After test the 'prog' templates you need to test it with to 'bootstrap' templates but it is not clear for me how to do, ask on koha-dev mailing list.

Comment 3 Marcel de Rooy 2013-11-25 14:37:28 UTC Comment hidden (obsolete)

Created attachment 23136 [details] [review]
BUG 11174 wrong parameter 'valuec'

In the templates opac-authoritiessearchresultlist of prog and
bootstrap the wrong value 'valuec' is changed with 'value'

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested with bootstrap.

Comment 4 Jonathan Druart 2013-12-13 11:38:05 UTC

Created attachment 23510 [details] [review]
BUG 11174 wrong paramter 'valuec'

In the templates opac-authoritiessearchresultlist of prog and
bootstrap the wrong value 'valuec' is changed with 'value'

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested with bootstrap.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Following commit remove the use to valuec:
 commit 31f41e2c1db9d8dca82e0249050acb8f906c8164
    Bug 8206: Specify index in OPAC authority search

Comment 5 Galen Charlton 2013-12-13 15:37:18 UTC

Pushed to master.  Thanks, Zeno!

Comment 6 Fridolin Somers 2013-12-24 11:57:24 UTC

Patch pushed to 3.14.x, will be in 3.14.2

Comment 7 Tomás Cohen Arazi (tcohen) 2014-01-15 17:15:55 UTC

This patch has been pushed to 3.12.x, will be in 3.12.9.

Thanks Zeno!