Summary: | The datatables filters don't work when several tables exist | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, m.de.rooy |
Version: | 3.14 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11205: The datatables filtering does not work when several tables exist
[SIGNED-OFF] Bug 11205: The datatables filtering does not work when several tables exist Bug 11205: The datatables filtering does not work when several tables exist |
Description
Jonathan Druart
2013-11-05 17:07:39 UTC
Created attachment 22739 [details] [review] Bug 11205: The datatables filtering does not work when several tables exist If there are more than 1 table on the same page, the datatable filters don't work. Test plan: 1/ Go on serials/serials-search.pl?searched=1 2/ filter on a column for opened subscriptions => the closed subscriptions should not be filtered. Created attachment 22744 [details] [review] [SIGNED-OFF] Bug 11205: The datatables filtering does not work when several tables exist If there are more than 1 table on the same page, the datatable filters don't work. Test plan: 1/ Go on serials/serials-search.pl?searched=1 2/ filter on a column for opened subscriptions => the closed subscriptions should not be filtered. Works! Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> If I click on one of the titles in the table where expiration date is blank, the following error occurs: Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /usr/share/koha/testclone/C4/Serials.pm line 2380 Could you confirm? If so, we should open a new report for that one.. I have a hard time to reproduce the error :) Somehow the filter on Open and Closed seems to work (also after refreshing) with and without this patch. Could you please clarify what you exactly mean with "more than 1 table on the page"? Or provide some more detailed steps to reproduce the problem encountered? Marcel, the only page with 2 tables is serials/serials-search.pl?searched=1 There are 2 tabs: opened and closed subscriptions. On each tabs there is a table. (In reply to M. de Rooy from comment #3) > If I click on one of the titles in the table where expiration date is blank, > the following error occurs: > > Date::Calc::PP::Delta_Days(): Usage: > Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at > /usr/share/koha/testclone/C4/Serials.pm line 2380 > > Could you confirm? If so, we should open a new report for that one.. I think it is not introduced by this patch. It would have been helpful to be somewhat more descriptive than just say "filters don't work". This could save some time in understanding what exactly the problem is. Your problem apparently was: If I filter on for instance a title word on the first tab (Opened), this filter should not be applied to the second tab (Closed). Your patch does resolve this situation. Thanks for that. No complaints from qa tools too. Passed QA Created attachment 22758 [details] [review] Bug 11205: The datatables filtering does not work when several tables exist If there are more than 1 table on the same page, the datatable filters don't work. Test plan: 1/ Go on serials/serials-search.pl?searched=1 2/ filter on a column for opened subscriptions => the closed subscriptions should not be filtered. Works! Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to M. de Rooy from comment #7) > It would have been helpful to be somewhat more descriptive than just say > "filters don't work". This could save some time in understanding what > exactly the problem is. Your problem apparently was: If I filter on for > instance a title word on the first tab (Opened), this filter should not be > applied to the second tab (Closed). > Your patch does resolve this situation. Thanks for that. Sorry Marcel, I thought step 2 of the test plan explained that clearly. Pushed to master and 3.14.x. Thanks, Jonathan! |