Summary: | Impossibility to remove a sms number | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall |
Version: | 3.14 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 11207: No way to remove a sms alert number
[SIGNED-OFF] Bug 11207: No way to remove a sms alert number [PASSED QA] Bug 11207: No way to remove a sms alert number |
Description
Jonathan Druart
2013-11-06 11:33:47 UTC
Created attachment 22748 [details] [review] Bug 11207: No way to remove a sms alert number Test plan: 1/ edit a patron 2/ set a sms alert number 3/ save 4/ edit the patron 5/ set the sms alert number to a blank value 6/ save 7/ the sms number is now an empty string Note: I don't understand the other test $input->param('SMSnumber') ne $newdata{'mobile'} Created attachment 22935 [details] [review] [SIGNED-OFF] Bug 11207: No way to remove a sms alert number Test plan: 1/ edit a patron 2/ set a sms alert number 3/ save 4/ edit the patron 5/ set the sms alert number to a blank value 6/ save 7/ the sms number is now an empty string Signed-off-by: Owen Leonard <oleonard@myacpl.org> I am sorry, but I can't reproduce the problem on current master. I have - activated the SMS functionality by giving a 'fake' SMSSendDriver of TEST - activated EnhancedMessagingPreferences - created a new patron, set sms number to 'test' - edited the patron and deleted 'test' - after saving it's gone and deleted from the database Katrin, I forgot something: If you edit the patron, the mobile number (other phone) has to be empty. If you fill it, you can delete the sms number. The bug is always reproducible on editing the step 5 (messaging pref) only: /members/memberentry.pl?op=modify&borrowernumber=XXXX&step=5 Hi Jonathan, I created a new patron so I am sure mobile was empty and I think I used the link on the page to only edit the prefs and not the 'full' patron - but I will give it another try. Created attachment 23056 [details] [review] [PASSED QA] Bug 11207: No way to remove a sms alert number Test plan: 1/ edit a patron 2/ set a sms alert number 3/ save 4/ edit the patron 5/ set the sms alert number to a blank value 6/ save 7/ the sms number is now an empty string Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Test plan used: - Activate the SMS functionality by giving a 'fake' SMSSendDriver of TEST - Activate EnhancedMessagingPreferences - Create a new patron, set Other phone to 'test' - Notice that Other phone was copied to sms number - Edit messaging preference section using the edit link below on the details tab and delete SMS number - Verify it's not possible to unset the SMS number - Apply patch - Repeat deleting - this time it works Pushed to master. Thanks, Jonathan! This patch has been pushed to 3.14.x, will be in 3.14.1 |