Summary: | Allow partial writeoff | ||
---|---|---|---|
Product: | Koha | Reporter: | Marjorie Barry-Vila <marjorie.barry-vila> |
Component: | Circulation | Assignee: | Gus Ellerm <ellermaugustus> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | black23, cbrannon, david.bourgault, ellermaugustus, fridolin.somers, george, gmcharlt, jonathan.druart, josef.moravec, kyle.m.hall, lisettepalouse+koha, nick, patrick.robitaille, rkuiper, sally.healey, simon.pouchol, tmisilo |
Version: | Main | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
URL: | http://devs.bywatersolutions.com/projects/allow-partial-writeoffs-of-fines/ | ||
Change sponsored?: | Seeking cosponsors | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 20120 | ||
Attachments: |
Bug 11210 - Writeoff partial amounts
Bug 11210 - Writeoff partial amounts Bug 11210 - Writeoff partial amounts Bug 11210 - Writeoff partial amounts Bug 11210 - Writeoff partial amounts Bug 11210 - Writeoff partial amounts |
Description
Marjorie Barry-Vila
2013-11-06 21:26:16 UTC
Seeking co-sponsors: http://devs.bywatersolutions.com/projects/allow-partial-writeoffs-of-fines/ I am glad to see this happen. It makes sense. Maybe this would be a good time to change this grouping of buttons in to an action button, defaulting to Pay all. Just a thought, since the number of buttons is growing. Created attachment 67345 [details] [review] Bug 11210 - Writeoff partial amounts Minor changes to pay.pl and paycollect.tt to allow writing off a partial amount of a fine. Test plan: 0) Go to the Fines tab of a test patron's profile 1) Create a fine if there are none (under the Manual invoice tab) 2) Go to the "Pay fines" tab 3) Press the write off button on the corresponding account line Without patch, you'll be asked to confirm, but will not be able to edit the amount With patch, you'll be able to edit the amount. Created attachment 67583 [details] [review] Bug 11210 - Writeoff partial amounts Minor changes to pay.pl and paycollect.tt to allow writing off a partial amount of a fine. Test plan: 0) Go to the Fines tab of a test patron's profile 1) Create a fine if there are none (under the Manual invoice tab) 2) Go to the "Pay fines" tab 3) Press the write off button on the corresponding account line Without patch, you'll be asked to confirm, but will not be able to edit the amount With patch, you'll be able to edit the amount. Followed test plan, patch worked as described. Also ran QA test tool and modified files passed Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Created attachment 68754 [details] [review] Bug 11210 - Writeoff partial amounts Minor changes to pay.pl and paycollect.tt to allow writing off a partial amount of a fine. Test plan: 0) Go to the Fines tab of a test patron's profile 1) Create a fine if there are none (under the Manual invoice tab) 2) Go to the "Pay fines" tab 3) Press the write off button on the corresponding account line Without patch, you'll be asked to confirm, but will not be able to edit the amount With patch, you'll be able to edit the amount. Followed test plan, patch worked as described. Also ran QA test tool and modified files passed Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Comment on attachment 68754 [details] [review] Bug 11210 - Writeoff partial amounts Review of attachment 68754 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ +191,5 @@ > + <ol> > + <li> > + <label for="paid">Writeoff amount: </label> > + <!-- default to writing off all --> > + <input name="amountwrittenoff" id="amountwrittenoff" value="[% amountoutstanding | format('%.2f') %]" /> No, price values must not be formatted when displayed in inputs. Created attachment 69001 [details] [review] Bug 11210 - Writeoff partial amounts Minor changes to pay.pl and paycollect.tt to allow writing off a partial amount of a fine. Test plan: 0) Go to the Fines tab of a test patron's profile 1) Create a fine if there are none (under the Manual invoice tab) 2) Go to the "Pay fines" tab 3) Press the write off button on the corresponding account line Without patch, you'll be asked to confirm, but will not be able to edit the amount With patch, you'll be able to edit the amount. Followed test plan, patch worked as described. Also ran QA test tool and modified files passed Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Removed the formatting on inputs. Created attachment 69090 [details] [review] Bug 11210 - Writeoff partial amounts Minor changes to pay.pl and paycollect.tt to allow writing off a partial amount of a fine. Test plan: 0) Go to the Fines tab of a test patron's profile 1) Create a fine if there are none (under the Manual invoice tab) 2) Go to the "Pay fines" tab 3) Press the write off button on the corresponding account line Without patch, you'll be asked to confirm, but will not be able to edit the amount With patch, you'll be able to edit the amount. Followed test plan, patch worked as described. Also ran QA test tool and modified files passed Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Created attachment 69420 [details] [review] Bug 11210 - Writeoff partial amounts Minor changes to pay.pl and paycollect.tt to allow writing off a partial amount of a fine. Test plan: 0) Go to the Fines tab of a test patron's profile 1) Create a fine if there are none (under the Manual invoice tab) 2) Go to the "Pay fines" tab 3) Press the write off button on the corresponding account line Without patch, you'll be asked to confirm, but will not be able to edit the amount With patch, you'll be able to edit the amount. Followed test plan, patch worked as described. Also ran QA test tool and modified files passed Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 18.05, thanks to everybody involved! Awesome work all! Pushed to stable for 17.11.02 Pushed to 17.05.x for v17.05.08 Small enhancement so I decided to push to oldstable branch |