Summary: | Allow create routing list in serial collection page | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Serials | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | colin.campbell, gmcharlt, liz |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11214 - Allow create routing list in serial collection page
Bug 11214 - Allow create routing list in serial collection page [PASSED QA] Bug 11214 - Allow create routing list in serial collection page |
Description
Fridolin Somers
2013-11-07 09:22:15 UTC
Created attachment 22763 [details] [review] Bug 11214 - Allow create routing list in serial collection page See commit message Created attachment 23043 [details] [review] Bug 11214 - Allow create routing list in serial collection page When a subscription has no routing list yet, the page serials/subscription-detail.pl shows in left menu : "Create routing list". In serials/serials-collection.pl page, the link in table is always "Edit routing list", even when there is no routing list. This patch adds a conditionnal link "Edit routing list"/"Create routing list" into serials/serials-collection.pl page. Test plan : - Create a subscription n°1 without routing list and a subscription n°2 with a routing list - Go to serials/serials-collection.pl of subscription n°1 => You see "Create routing list" link - Click on link => You see "Create routing list for" - Go to serials/serials-collection.pl of subscription n°2 => You see "Edit routing list" link - Click on link => You see "Edit routing list for ..." Signed-off-by: Liz Rea <liz@catalyst.net.nz> Functional and automated tests pass. Passes koha-qa.pl. Created attachment 23127 [details] [review] [PASSED QA] Bug 11214 - Allow create routing list in serial collection page When a subscription has no routing list yet, the page serials/subscription-detail.pl shows in left menu : "Create routing list". In serials/serials-collection.pl page, the link in table is always "Edit routing list", even when there is no routing list. This patch adds a conditionnal link "Edit routing list"/"Create routing list" into serials/serials-collection.pl page. Test plan : - Create a subscription no. 1 without routing list and a subscription no. 2 with a routing list - Go to serials/serials-collection.pl of subscription no. 1 => You see "Create routing list" link - Click on link => You see "Create routing list for" - Go to serials/serials-collection.pl of subscription no. 2 => You see "Edit routing list" link - Click on link => You see "Edit routing list for ..." Signed-off-by: Liz Rea <liz@catalyst.net.nz> Functional and automated tests pass. Passes koha-qa.pl. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. With the patch applied the serial collection page shows the right link depending on the existance of a routing list. Pushed to master. Thanks, Fridolin! This patch has been pushed to 3.14.x, will be in 3.14.1 |