Summary: | Incorrect ind 1 semantics for MARC21 785 on the detail page in staff | ||
---|---|---|---|
Product: | Koha | Reporter: | drigney |
Component: | Staff interface | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | gmcharlt, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00
|
|
Circulation function: | |||
Bug Depends on: | 15437 | ||
Bug Blocks: | |||
Attachments: |
Bug 11223: Fix the ind1 semantics for 785 in the staff interface
Bug 11223: Fix the ind1 semantics for 785 in the staff interface Bug 11223: Fix the ind1 semantics for 785 in the staff interface |
Description
drigney
2013-11-08 19:31:57 UTC
Still valid. Created attachment 110517 [details] [review] Bug 11223: Fix the ind1 semantics for 785 in the staff interface For 780 and 785 the field should not display when the first indicator is 1. After checking the code, I found that 785 in staff was missing. This patches fixes that one. To test: - Catalog a record with 785 and 780 fields with one 1st indicator set to 0 and another to 1. - Verify in staff and OPAC detail pages that only the fields with 0 display. Created attachment 110525 [details] [review] Bug 11223: Fix the ind1 semantics for 785 in the staff interface For 780 and 785 the field should not display when the first indicator is 1. After checking the code, I found that 785 in staff was missing. This patches fixes that one. To test: - Catalog a record with 785 and 780 fields with one 1st indicator set to 0 and another to 1. - Verify in staff and OPAC detail pages that only the fields with 0 display. Signed-off-by: David Nind <david@davidnind.com> Thx, David! Created attachment 110743 [details] [review] Bug 11223: Fix the ind1 semantics for 785 in the staff interface For 780 and 785 the field should not display when the first indicator is 1. After checking the code, I found that 785 in staff was missing. This patches fixes that one. To test: - Catalog a record with 785 and 780 fields with one 1st indicator set to 0 and another to 1. - Verify in staff and OPAC detail pages that only the fields with 0 display. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Another sane and sensible XSLT fix, thanks Katrin Passing QA Pushed to master for 20.11, thanks to everybody involved! missing 20.05.x dependencies, no backport Hm, maybe instead of checking ind1=0 it would be safer to check ind1!=1, so people that don't catalog the indicators are on the safe side. Need to verify still. |