Summary: | Staff po files contain some Javascript | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | I18N/L10N | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | bgkriegel, f.demians, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11227 - Staff po files contain some Javascript
[SIGNED-OFF] Bug 11227 - Staff po files contain some Javascript [PASSED QA] Bug 11227 - Staff po files contain some Javascript |
Description
Katrin Fischer
2013-11-09 19:54:41 UTC
Created attachment 26793 [details] [review] Bug 11227 - Staff po files contain some Javascript This patch rewrites authorities_js.inc so translate script process it correctly. To that I add <script></script> at the file To test: 1) Update po files for your preffered language 2) Check occurrence of mergeAuth on staff PO file or try egrep -n "Merging with authority: |Cancel merge" strings appear in a JS func 3) Apply the patch 4) Update translations again, chech again, old strings now begin with #~ (obsoleted) and there are new entries for the messages 5) Check functionality provided by script Created attachment 27369 [details] [review] [SIGNED-OFF] Bug 11227 - Staff po files contain some Javascript This patch rewrites authorities_js.inc so translate script process it correctly. To that I add <script></script> at the file To test: 1) Update po files for your preffered language 2) Check occurrence of mergeAuth on staff PO file or try egrep -n "Merging with authority: |Cancel merge" strings appear in a JS func 3) Apply the patch 4) Update translations again, chech again, old strings now begin with #~ (obsoleted) and there are new entries for the messages 5) Check functionality provided by script Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 27672 [details] [review] [PASSED QA] Bug 11227 - Staff po files contain some Javascript This patch rewrites authorities_js.inc so translate script process it correctly. To that I add <script></script> at the file To test: 1) Update po files for your preffered language 2) Check occurrence of mergeAuth on staff PO file or try egrep -n "Merging with authority: |Cancel merge" strings appear in a JS func 3) Apply the patch 4) Update translations again, chech again, old strings now begin with #~ (obsoleted) and there are new entries for the messages 5) Check functionality provided by script Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described and fixes a translation difficulty. Pushed to master. Thanks, Bernardo! |