Summary: | Explanation on 'patron notification' is not quite right | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Serials | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | colin.campbell, fridolin.somers, gmcharlt, nengard, tomascohen |
Version: | 3.14 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | String patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Screenshot of subscription add form
Bug 11228: Improve hint on patron notification when adding/editing subscriptions Bug 11228: Improve hint on patron notification when adding/editing subscriptions Bug 11228: Improve hint on patron notification when adding/editing subscriptions |
I have done some more digging to make sure, that routing lists and patron notification are unrelated. From reading the code this is the case, I have looked at getalert, SendAlerts and addalert - there is no reference to routing lists. Created attachment 23324 [details] [review] Bug 11228: Improve hint on patron notification when adding/editing subscriptions The hint was not quite correct, as it said patrons on the routing list would be informed, but it's the patrons that have subscribed to email notifications in the OPAC, that will receive the email when a new serial issue is received. To test: - Add a new subscription, find the hint about patron notification on the form - Apply patch - Refresh page - Verify the new hint text makes sense and is correct Created attachment 23660 [details] [review] Bug 11228: Improve hint on patron notification when adding/editing subscriptions The hint was not quite correct, as it said patrons on the routing list would be informed, but it's only the patrons that have subscribed to email notifications in the OPAC who will receive the email when a new serial issue is received. To test: - Add a new subscription, find the hint about patron notification on the form - Apply patch - Refresh page - Verify the new hint text makes sense and is correct Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 23666 [details] [review] Bug 11228: Improve hint on patron notification when adding/editing subscriptions The hint was not quite correct, as it said patrons on the routing list would be informed, but it's only the patrons that have subscribed to email notifications in the OPAC who will receive the email when a new serial issue is received. To test: - Add a new subscription, find the hint about patron notification on the form - Apply patch - Refresh page - Verify the new hint text makes sense and is correct Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Katrin! Patch pushed to 3.14.x, will be in 3.14.3. Can someone confirm that this edit to the manual is correct: http://git.koha-community.org/gitweb/?p=kohadocs.git;a=commitdiff;h=29377fa98448112cc7b138e9dd6c5960c7500c1c With help on IRC I have updated the manual: http://manual.koha-community.org/3.14/en/routinglist.html http://manual.koha-community.org/3.14/en/newsubscription.html http://manual.koha-community.org/3.14/en/serialsubinopac.html |
Created attachment 22849 [details] Screenshot of subscription add form The subscription details form states as explanation for the patron notifications pull down: "Select a notice and patrons on the routing list will be notified when new issues are received." This is not quite right, as the notices will only be sent out when you have subscribed to them from the OPAC. The routing list patrons won't receive the notice unless they have subscribed before. In that context the notices template named RLIST should be renamed too, so this is less confusing.