|
Description
Peggy Thrasher
2013-11-15 14:58:26 UTC
Hi Peggy, I think we could also change the sample notices to include the <<items.content>> line - maybe that would make people notice. The most complete documentation that we have for notices and slips markup is at https://wiki.koha-community.org/wiki/Customising_Notices_and_Slips#Notice_Specific_Markup The page is current (although slightly incommplete) as of 16.11. There is an out-dated version of that page under 'Field Guide for Notices & Slips' https://koha-community.org/manual/16.11/html/apd.html#noticesfieldguide Current sample notice for (PRE)DUEDGST just reads: You have <<count>> items due Certainly room for improvement there! Hi all, is this still relevant? If yes can you please clarify what the desired solution is here? I opened Bug 27237 today to include <<items.content>> by default for PREDUEDST. I guess it's actually a duplicate of this one. I don't plan to actually work on Bug 27237, so I'll mark it as a duplicate, but my comment there might be useful here. *** Bug 27237 has been marked as a duplicate of this bug. *** I think the idea was to change the sample notice text to make it read more similar to the existing other notices and add some more information about the items which can be done using the items.content placeholder. Not sure if we should/could just switch them over to TT syntax instead? (In reply to Katrin Fischer from comment #7) > I think the idea was to change the sample notice text to make it read more > similar to the existing other notices and add some more information about > the items which can be done using the items.content placeholder. > > Not sure if we should/could just switch them over to TT syntax instead? Yeah could probably do that too. It's not something I'm planning on working on but I raised that (duplicate) bug as I went to update an existing install the other day and was surprised at how the PREDUEDGST sample was not usable. Created attachment 115374 [details] [review] Bug 11257: PREDUEDST should have more useful default text This patch changes the default text of PEDUEDST to the following: Dear <<borrowers.firstname>> <<borrowers.surname>>, The following item(s) will be due soon: <<items.content>> Note: I dont beleive ive done everything requesting in the bug, ie there was a request to add <<items.content>> to the documentation of sample_notices.yml, but I couldn't find documentation for it. If there's things I missed, please tell me so I can make the appropraite changes, or feel free to make the changes yourself. Test plan: 1. Select "edit" on PREDUEDST in the notices and slips page (Home -> tools -> Notices and slips) 2. Open "email", and note the default text. 3. Apply the patch, and peform a fresh install of Koha. 4. Navigate to the same page. The default text should have changed. https://bugs.koha-community.org/show_bug.cgi?id=27237 Hi James, I really like the new version much better. I am going to sign off. Could you maybe do a follow up for the DUEDGST? Both are almost the same. Created attachment 115585 [details] [review] Bug 11257: PREDUEDST should have more useful default text This patch changes the default text of PEDUEDST to the following: Dear <<borrowers.firstname>> <<borrowers.surname>>, The following item(s) will be due soon: <<items.content>> Note: I dont beleive ive done everything requesting in the bug, ie there was a request to add <<items.content>> to the documentation of sample_notices.yml, but I couldn't find documentation for it. If there's things I missed, please tell me so I can make the appropraite changes, or feel free to make the changes yourself. Test plan: 1. Select "edit" on PREDUEDST in the notices and slips page (Home -> tools -> Notices and slips) 2. Open "email", and note the default text. 3. Apply the patch, and peform a fresh install of Koha. 4. Navigate to the same page. The default text should have changed. https://bugs.koha-community.org/show_bug.cgi?id=27237 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Katrin Fischer from comment #10) > Hi James, I really like the new version much better. I am going to sign off. > Could you maybe do a follow up for the DUEDGST? Both are almost the same. Sure! I'll make those changes. I've also noticed a lot of similar example notices use "<<biblio.title>>, <<biblio.author>>, (<<items.barcode>>)" rather than "<<items.content>>". Do you think it'd be worth changing all instances of the longer version to <<items.content>> for consistency and ease of reading, or would it be a waste of time? Created attachment 115625 [details] [review] Bug 11257: (followup) Document <<items.content>> for DUEDGST and PREDUEDGST and update sample notices This patch changes the default text for the DUEDGST sample notice to the following: Dear <<borrowers.firstname>> <<borrowers.surname>>, The following item(s) are due: <<items.content>> (it does not include an atomic update) Test plan: 1. Select "edit" on DUEDGST in the notices and slips page (Home -> tools -> Notices and slips) 2. Open "email", and note the default text. 3. Apply the patch, and peform a fresh install of Koha. 4. Navigate to the same page. The default text should have changed. (In reply to James O'Keeffe from comment #12) > (In reply to Katrin Fischer from comment #10) > > Hi James, I really like the new version much better. I am going to sign off. > > Could you maybe do a follow up for the DUEDGST? Both are almost the same. > > Sure! I'll make those changes. I've also noticed a lot of similar example > notices use "<<biblio.title>>, <<biblio.author>>, (<<items.barcode>>)" > rather than "<<items.content>>". Do you think it'd be worth changing all > instances of the longer version to <<items.content>> for consistency and > ease of reading, or would it be a waste of time? Thx James! <<items.content>> only works in some specific notices, so we need to keep the others as they are :) Created attachment 115628 [details] [review] Bug 11257: PREDUEDST should have more useful default text This patch changes the default text of PEDUEDST to the following: Dear <<borrowers.firstname>> <<borrowers.surname>>, The following item(s) will be due soon: <<items.content>> Note: I dont beleive ive done everything requesting in the bug, ie there was a request to add <<items.content>> to the documentation of sample_notices.yml, but I couldn't find documentation for it. If there's things I missed, please tell me so I can make the appropraite changes, or feel free to make the changes yourself. Test plan: 1. Select "edit" on PREDUEDST in the notices and slips page (Home -> tools -> Notices and slips) 2. Open "email", and note the default text. 3. Apply the patch, and peform a fresh install of Koha. 4. Navigate to the same page. The default text should have changed. https://bugs.koha-community.org/show_bug.cgi?id=27237 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 115629 [details] [review] Bug 11257: (followup) Document <<items.content>> for DUEDGST and PREDUEDGST and update sample notices This patch changes the default text for the DUEDGST sample notice to the following: Dear <<borrowers.firstname>> <<borrowers.surname>>, The following item(s) are due: <<items.content>> (it does not include an atomic update) Test plan: 1. Select "edit" on DUEDGST in the notices and slips page (Home -> tools -> Notices and slips) 2. Open "email", and note the default text. 3. Apply the patch, and peform a fresh install of Koha. 4. Navigate to the same page. The default text should have changed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 115630 [details] [review] Bug 11257: (QA follow-up) Add thank you Even if we are grumpy because they still have not returned the items, we should be nice :) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 115672 [details] [review] Bug 11257: PREDUEDST should have more useful default text This patch changes the default text of PEDUEDST to the following: Dear <<borrowers.firstname>> <<borrowers.surname>>, The following item(s) will be due soon: <<items.content>> Note: I dont beleive ive done everything requesting in the bug, ie there was a request to add <<items.content>> to the documentation of sample_notices.yml, but I couldn't find documentation for it. If there's things I missed, please tell me so I can make the appropraite changes, or feel free to make the changes yourself. Test plan: 1. Select "edit" on PREDUEDST in the notices and slips page (Home -> tools -> Notices and slips) 2. Open "email", and note the default text. 3. Apply the patch, and peform a fresh install of Koha. 4. Navigate to the same page. The default text should have changed. https://bugs.koha-community.org/show_bug.cgi?id=27237 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 115673 [details] [review] Bug 11257: (followup) Document <<items.content>> for DUEDGST and PREDUEDGST and update sample notices This patch changes the default text for the DUEDGST sample notice to the following: Dear <<borrowers.firstname>> <<borrowers.surname>>, The following item(s) are due: <<items.content>> (it does not include an atomic update) Test plan: 1. Select "edit" on DUEDGST in the notices and slips page (Home -> tools -> Notices and slips) 2. Open "email", and note the default text. 3. Apply the patch, and peform a fresh install of Koha. 4. Navigate to the same page. The default text should have changed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 115674 [details] [review] Bug 11257: (QA follow-up) Add thank you Even if we are grumpy because they still have not returned the items, we should be nice :) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 115868 [details] [review] Bug 11257: PREDUEDST should have more useful default text This patch changes the default text of PEDUEDST to the following: Dear <<borrowers.firstname>> <<borrowers.surname>>, The following item(s) will be due soon: <<items.content>> Note: I dont beleive ive done everything requesting in the bug, ie there was a request to add <<items.content>> to the documentation of sample_notices.yml, but I couldn't find documentation for it. If there's things I missed, please tell me so I can make the appropraite changes, or feel free to make the changes yourself. Test plan: 1. Select "edit" on PREDUEDST in the notices and slips page (Home -> tools -> Notices and slips) 2. Open "email", and note the default text. 3. Apply the patch, and peform a fresh install of Koha. 4. Navigate to the same page. The default text should have changed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> JD amended patch: Remove double spaces in PREDUEDST Created attachment 115869 [details] [review] Bug 11257: (followup) Document <<items.content>> for DUEDGST and PREDUEDGST and update sample notices This patch changes the default text for the DUEDGST sample notice to the following: Dear <<borrowers.firstname>> <<borrowers.surname>>, The following item(s) are due: <<items.content>> (it does not include an atomic update) Test plan: 1. Select "edit" on DUEDGST in the notices and slips page (Home -> tools -> Notices and slips) 2. Open "email", and note the default text. 3. Apply the patch, and peform a fresh install of Koha. 4. Navigate to the same page. The default text should have changed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 115870 [details] [review] Bug 11257: (QA follow-up) Add thank you Even if we are grumpy because they still have not returned the items, we should be nice :) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 21.05, thanks to everybody involved! Small enhancement, I choose to backport. Pushed to 20.11.x for 20.11.03 Enhancement, not backporting to 20.05. Please request if needed. |