Summary: | copy submit button on inventory | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Nicole C. Engard <nengard> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle, m.de.rooy, mtompset, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12025 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
[BUG 11272] Add second submit button to inventory
[SIGNED-OFF] Bug 11272 - copy submit button on inventory Bug 11272 - copy submit button on inventory Bug 11272 - copy submit button on inventory [Signed-off] Bug 11272 - copy submit button on inventory |
Description
Nicole C. Engard
2013-11-19 16:27:54 UTC
Created attachment 24705 [details] [review] [BUG 11272] Add second submit button to inventory The inventory tool allows for 2 ways of processing files. The first is to upload a file. The second is to generate the shelf list. Most libraries think they have to fill in all fields because the submit button is at the bottom of the second option. They do not. This patch adds a second submit button under the first method to make this clearer. To test: * Generate a file of barcodes for inventorying * Before applying the patch use the file upload method to mark as seen * Apply the patch * Use the file upload method to mark as seen using the new submit * Repeat the above for the shelf list method * Confirm that inventory still works as expected with 2 buttons Created attachment 24893 [details] [review] [SIGNED-OFF] Bug 11272 - copy submit button on inventory The inventory tool allows for 2 ways of processing files. The first is to upload a file. The second is to generate the shelf list. Most libraries think they have to fill in all fields because the submit button is at the bottom of the second option. They do not. This patch adds a second submit button under the first method to make this clearer. To test: * Generate a file of barcodes for inventorying * Before applying the patch use the file upload method to mark as seen * Apply the patch * Use the file upload method to mark as seen using the new submit * Repeat the above for the shelf list method * Confirm that inventory still works as expected with 2 buttons Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 24934 [details] [review] Bug 11272 - copy submit button on inventory The inventory tool allows for 2 ways of processing files. The first is to upload a file. The second is to generate the shelf list. Most libraries think they have to fill in all fields because the submit button is at the bottom of the second option. They do not. This patch adds a second submit button under the first method to make this clearer. To test: * Generate a file of barcodes for inventorying * Before applying the patch use the file upload method to mark as seen * Apply the patch * Use the file upload method to mark as seen using the new submit * Repeat the above for the shelf list method * Confirm that inventory still works as expected with 2 buttons Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Passing QA on this trivial patch adding a submit button on inventory, but I feel that this form actually needs more attention as for design. Just viewing this as a workaround. The form design is not intuitive. The two approaches should be more visible, as well as common options to both approaches like exporting to csv etc. Pushed to master. Thanks, Nicole! I agree with Marcel that the form needs a revamp to make it clear that it has two distinct modes of operation. Pushed to 3.14.x, will be in 3.14.07 Pushed to 3.12.x will be in 3.12.13 I'm wondering if this got reverted. I'm on 3.16 (and I have a master system as well) and I don't see the button anymore. Can anyone confirm? Nicole Created attachment 37850 [details] [review] Bug 11272 - copy submit button on inventory The inventory tool allows for 2 ways of processing files. The first is to upload a file. The second is to generate the shelf list. Most libraries think they have to fill in all fields because the submit button is at the bottom of the second option. They do not. This patch adds a second submit button under the first method to make this clearer. To test: * Generate a file of barcodes for inventorying * Before applying the patch use the file upload method to mark as seen * Apply the patch * Use the file upload method to mark as seen using the new submit * Repeat the above for the shelf list method * Confirm that inventory still works as expected with 2 buttons Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Rebased. I wasn't sure what status to stick this to. If you compare it to the previous obsolete, it's identical. For some strange reason the extra blank lines confused the git bz apply such that it didn't apply. This one does. Created attachment 37895 [details] [review] [Signed-off] Bug 11272 - copy submit button on inventory The inventory tool allows for 2 ways of processing files. The first is to upload a file. The second is to generate the shelf list. Most libraries think they have to fill in all fields because the submit button is at the bottom of the second option. They do not. This patch adds a second submit button under the first method to make this clearer. To test: * Generate a file of barcodes for inventorying * Before applying the patch use the file upload method to mark as seen * Apply the patch * Use the file upload method to mark as seen using the new submit * Repeat the above for the shelf list method * Confirm that inventory still works as expected with 2 buttons Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Rebased. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Mark, please have a look at the historic of the report before reintroduce a dead patch. It will take you to bug 12025 comment 4. This is "resolved" as it is pushed to master and stable versions. Open a new bug for discussion if needed. (In reply to Jonathan Druart from comment #13) > Mark, please have a look at the historic of the report before reintroduce a > dead patch. It will take you to bug 12025 comment 4. Apologies. I was just working at lowering the "Patch does not apply" queue. I should have been a little more thorough in checking git logs, and noting see also's above. |