| Summary: | Barcode generation hbyymmincr (AutoBarcode) in acquisitions is broken | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, liz, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10890 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425 |
||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 11273: FIX barcode generation in acquisition if hbyymmincr
[Signed-off] Bug 11273: FIX barcode generation in acquisition if hbyymmincr [PASSED QA] Bug 11273: FIX barcode generation in acquisition if hbyymmincr |
||
|
Description
Katrin Fischer
2013-11-19 22:16:02 UTC
Katrin, Please detail, I don't reproduce. I set the AutoBarcode to incremental and when I go on acqui/neworderempty.pl?booksellerid=1&basketno=1 and click on the plugin link, the barcode field is correctly filled. Moreover I don't get the JS error. Hi Jonathan, aah, I think I know what happened - I used the filter with the branchcode. Does this work for you? No, same error as you with the value "hbyymmincr". So only the incrmental works? No, only hbyymmincr does not work. Ah, I misunderstood, thx for clarifying. Still valid. Created attachment 40989 [details] [review] Bug 11273: FIX barcode generation in acquisition if hbyymmincr When AutoBarcode is activated and you have set AcqCreateItem to 'on order' there is a Javascript error when you try to generate a barcode for the item: TypeError: document.f is undefined http://localhost:8080/intranet-tmpl/lib/jquery/jquery.js Line 11 Test plan: 0/ a. Set AutoBarcode to hbyymmincr b. Set AcqCreateItem to 'on ordering' c. Set the plugin barcode.pl to the barcode field for the default and the ACQ frameworks 1/ Go on the add items page (cataloguing/additem.pl) and confirm that the plugin works as expected. 2/ Go on the New order page (acqui/neworderempty.pl) and confirm that the plugin works as expected. Created attachment 42104 [details] [review] [Signed-off] Bug 11273: FIX barcode generation in acquisition if hbyymmincr When AutoBarcode is activated and you have set AcqCreateItem to 'on order' there is a Javascript error when you try to generate a barcode for the item: TypeError: document.f is undefined http://localhost:8080/intranet-tmpl/lib/jquery/jquery.js Line 11 Test plan: 0/ a. Set AutoBarcode to hbyymmincr b. Set AcqCreateItem to 'on ordering' c. Set the plugin barcode.pl to the barcode field for the default and the ACQ frameworks 1/ Go on the add items page (cataloguing/additem.pl) and confirm that the plugin works as expected. 2/ Go on the New order page (acqui/neworderempty.pl) and confirm that the plugin works as expected. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> This improves the situation, but there is still a problem when you are creating more than one item - the plugin will always create the same barcode for each. Created attachment 42372 [details] [review] [PASSED QA] Bug 11273: FIX barcode generation in acquisition if hbyymmincr When AutoBarcode is activated and you have set AcqCreateItem to 'on order' there is a Javascript error when you try to generate a barcode for the item: TypeError: document.f is undefined http://localhost:8080/intranet-tmpl/lib/jquery/jquery.js Line 11 Test plan: 0/ a. Set AutoBarcode to hbyymmincr b. Set AcqCreateItem to 'on ordering' c. Set the plugin barcode.pl to the barcode field for the default and the ACQ frameworks 1/ Go on the add items page (cataloguing/additem.pl) and confirm that the plugin works as expected. 2/ Go on the New order page (acqui/neworderempty.pl) and confirm that the plugin works as expected. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Katrin Fischer from comment #10) > This improves the situation, but there is still a problem when you are > creating more than one item - the plugin will always create the same barcode > for each. Is it a regression? Nope - it's as before with the other - just annoying. That's why this passed QA :) Yes but I meant: This has already worked before? in 3.18 for instance (In reply to Jonathan Druart from comment #14) > Yes but I meant: This has already worked before? in 3.18 for instance Known bug, see bug 8425. Patch pushed to master. Thanks Jonathan! Pushed to 3.20.x will be in 3.20.4 Pushed to 3.18.x will be in 3.18.11 |