Summary: | Restriction type is not translatable | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Patrons | Assignee: | Kyle M Hall (khall) <kyle> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall |
Version: | 3.14 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 2720 | ||
Bug Blocks: | |||
Attachments: |
Bug 11283 - Restriction type is not translatable
[SIGNED OFF] Bug 11283 - Restriction type is not translatable Bug 11283 - Restriction type is not translatable |
Description
Katrin Fischer
2013-11-21 22:28:19 UTC
Created attachment 23081 [details] [review] Bug 11283 - Restriction type is not translatable The new restrictions system has different types: MANUAL, OVERDUES and SUSPENSION. Those are shown in the interface and seem to come directly from the database, so they are not translatable. As they are hardcoded translations should be possible and be handled in the template. Test Plan: 1) Create a patron with one of each type of restriction 2) Apply this patch 3) Note you see the type with only the first letter capitialized, this indicates you are seeing the translatable string Created attachment 23117 [details] [review] [SIGNED OFF] Bug 11283 - Restriction type is not translatable The new restrictions system has different types: MANUAL, OVERDUES and SUSPENSION. Those are shown in the interface and seem to come directly from the database, so they are not translatable. As they are hardcoded translations should be possible and be handled in the template. Test Plan: 1) Create a patron with one of each type of restriction 2) Apply this patch 3) Note you see the type with only the first letter capitialized, this indicates you are seeing the translatable string Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Strings now appear in updated po files: msgid "%s %s Manual %s Overdues %s Suspension %s " Created attachment 23189 [details] [review] Bug 11283 - Restriction type is not translatable The new restrictions system has different types: MANUAL, OVERDUES and SUSPENSION. Those are shown in the interface and seem to come directly from the database, so they are not translatable. As they are hardcoded translations should be possible and be handled in the template. Test Plan: 1) Create a patron with one of each type of restriction 2) Apply this patch 3) Note you see the type with only the first letter capitialized, this indicates you are seeing the translatable string Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Strings now appear in updated po files: msgid "%s %s Manual %s Overdues %s Suspension %s " Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Kyle! This patch has been pushed to 3.14.x, will be in 3.14.1 |