Bug 11286

Summary: Bug 10602 prevents to create new subfields in authorities
Product: Koha Reporter: Sophie MEYNIEUX <sophie.meynieux>
Component: CatalogingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: bgkriegel, fridolin.somers, gmcharlt, m.de.rooy, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 10602    
Bug Blocks:    
Attachments: Bug 11286: FIX Add a new subfield to an authority frameworks
[SIGNED-OFF] Bug 11286: FIX Add a new subfield to an authority frameworks
[PASSED QA] Bug 11286: FIX Add a new subfield to an authority frameworks

Description Sophie MEYNIEUX 2013-11-22 09:29:28 UTC
Default value for authorities, added by Bug 10602, was forgotten in insert query, preventing to add new subfields in authorities
Comment 1 Jonathan Druart 2013-11-22 09:47:46 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-11-24 21:29:25 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-11-24 22:21:15 UTC
Created attachment 23123 [details] [review]
[PASSED QA] Bug 11286: FIX Add a new subfield to an authority frameworks

Bug 10602 introduces a bug when adding a new subfield to an authority
framework. A new parameter is added in a sql query but the placeholder
is missing.

Test plan:
- edit an authority framework
- add a new subfield
- save
- boom!
DBD::mysql::st execute failed: called with 16 bind variables when 15 are
needed at
/home/home/src/admin/auth_subfields_structure.pl line 454.
- apply the patch and try again

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described. No koha-qa errors

Tested trying to add subfield to 100, 2 for example.
Without patch silently fails (but error is logged)
With patch subfield creation or elimination is fine

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
One line fix for a bad bug. Confirmed the bug on master and
the fix. Passes all tests and QA script.
Comment 4 Galen Charlton 2013-11-27 18:09:05 UTC
Pushed to master.  Thanks, Jonathan!
Comment 5 Fridolin Somers 2013-12-13 14:24:56 UTC
This patch has been pushed to 3.14.x, will be in 3.14.1