Summary: | Bootstrap OPAC detail page doesn't display holding tabs properly | ||
---|---|---|---|
Product: | Koha | Reporter: | Frédéric Demians <f.demians> |
Component: | OPAC | Assignee: | Frédéric Demians <f.demians> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
Bug 11304 Bootstrap OPAC detail page doesn't display holding tabs properly [PASSED QA] Bug 11304 Bootstrap OPAC detail page doesn't display holding tabs properly |
Description
Frédéric Demians
2013-11-26 10:34:44 UTC
Created attachment 23156 [details] [review] Proposed patch Bug 11304 Bootstrap OPAC detail page doesn't display holding tabs properly Detail page tabs are not displayed properly because JavaScript is broken in French. This is due to _(' JS string construction used in place of _(". This patch fixes: - opac-detail.tt page - xt/single_quotes to test bootstrap theme Created attachment 23159 [details] [review] Bug 11304 Bootstrap OPAC detail page doesn't display holding tabs properly Detail page tabs are not displayed properly because JavaScript is broken in French. This is due to _(' JS string construction used in place of _(". This patch fixes: - opac-detail.tt page - xt/single_quotes to test bootstrap theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested by applying the patch, running translate update, then translate install. Saw no JavaScript error on the French detail page. Created attachment 23183 [details] [review] [PASSED QA] Bug 11304 Bootstrap OPAC detail page doesn't display holding tabs properly Detail page tabs are not displayed properly because JavaScript is broken in French. This is due to _(' JS string construction used in place of _(". This patch fixes: - opac-detail.tt page - xt/single_quotes to test bootstrap theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested by applying the patch, running translate update, then translate install. Saw no JavaScript error on the French detail page. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Switches from single to double quotes for translatatable strings. Unit tests for xt/single_quotes passes now. Pushed to master. Thanks, Frédéric! This patch has been pushed to 3.14.x, will be in 3.14.1 PS : 2 single quotes remains, but they are not in a translated text : data.rating_total + ' ' + _("votes") |