Summary: | Perldoc issues in misc/cronjobs/advance_notices.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Barton Chittenden <bartonski> |
Component: | Command-line Utilities | Assignee: | James O'Keeffe <jamespfk> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | andrewfh, caroline.cyr-la-rose, fridolin.somers, jamespfk, jonathan.druart, katrin.fischer, m.de.rooy, victor |
Version: | master | Keywords: | Academy |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.05.00,20.11.03,20.05.09,19.11.15
|
|
Attachments: |
Bug 11344: Perldoc issues in misc/cronjobs/advance_notices.pl
Bug 11344: Perldoc issues in misc/cronjobs/advance_notices.pl Bug 11344: Perldoc issues in misc/cronjobs/advance_notices.pl Bug 11344: (QA follow-up) Fix empty section warning |
Description
Barton Chittenden
2013-12-05 17:47:00 UTC
Created attachment 115363 [details] [review] Bug 11344: Perldoc issues in misc/cronjobs/advance_notices.pl This patch removes the double ups in the perldoc of the above file, deleting the less clear double ups. The missing "-c" in OPTIONS appears to have been fixed in an earlier patch (it is there already). Task Plan: 1. Run perldoc misc/cronjobs/advance_notices.pl in the terminal. Note the double ups of NAME, SYNOPSIS, and DESCRIPTION 2. Apply the patch 3. Run the command again. The double ups should be gone, with the more clear version of each of NAME, SYNOPSIS, and DESCRIPTION remaining. Created attachment 115586 [details] [review] Bug 11344: Perldoc issues in misc/cronjobs/advance_notices.pl This patch removes the double ups in the perldoc of the above file, deleting the less clear double ups. The missing "-c" in OPTIONS appears to have been fixed in an earlier patch (it is there already). Task Plan: 1. Run perldoc misc/cronjobs/advance_notices.pl in the terminal. Note the double ups of NAME, SYNOPSIS, and DESCRIPTION 2. Apply the patch 3. Run the command again. The double ups should be gone, with the more clear version of each of NAME, SYNOPSIS, and DESCRIPTION remaining. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I believe this is a good step in the right direction! There is a note in the QA tools about a POD error still: FAIL misc/cronjobs/advance_notices.pl OK critic OK forbidden patterns OK git manipulation FAIL pod *** WARNING: empty section in previous paragraph in file misc/cronjobs/advance_notices.pl If you get a chance today, please check if you can fix this as well! Created attachment 115667 [details] [review] Bug 11344: Perldoc issues in misc/cronjobs/advance_notices.pl This patch removes the double ups in the perldoc of the above file, deleting the less clear double ups. The missing "-c" in OPTIONS appears to have been fixed in an earlier patch (it is there already). Task Plan: 1. Run perldoc misc/cronjobs/advance_notices.pl in the terminal. Note the double ups of NAME, SYNOPSIS, and DESCRIPTION 2. Apply the patch 3. Run the command again. The double ups should be gone, with the more clear version of each of NAME, SYNOPSIS, and DESCRIPTION remaining. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 115668 [details] [review] Bug 11344: (QA follow-up) Fix empty section warning *** WARNING: empty section in previous paragraph at line 28 in file misc/cronjobs/advance_notices.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> We lost the reference to the crontab, was it expected? Pushed to master for 21.05, thanks to everybody involved! Pushed to 20.11.x for 20.11.03 Pushed to 20.05.x for 20.05.09 Backported: Pushed to 19.11.x branch for 19.11.15 |