Bug 11347

Summary: PROG/CCSR deprecation: Remove opacsmallimage system-preference
Product: Koha Reporter: Liz Rea <liz>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: bgkriegel, chris, olli-antti.kivilahti, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 11346    
Attachments: Bug 11347 - PROG/CCSR deprecation: Remove opacsmallimage system-preference
[SIGNED-OFF] Bug 11347 - PROG/CCSR deprecation: Remove opacsmallimage system-preference
[PASSED QA] Bug 11347 - PROG/CCSR deprecation: Remove opacsmallimage system-preference

Description Liz Rea 2013-12-05 21:49:24 UTC
the opacsmallimage system preference is unused in the bootstrap theme, it should be removed when the themes are removed. 

To replace the functionality of customizing the logo in the top corner, one would use CSS to change the background of #logo.
Comment 1 Olli-Antti Kivilahti 2014-05-08 12:49:36 UTC
BTW

Adding a new css directive

#logo { background:transparent url("../images/vaara-kirjastot-logo-medium.png") no-repeat scroll 0;
        border:0;
        float:left!important;
        margin:0;
        padding:0;
        width: 163px;
        height: 50px;
        } 

to overwrite the one in opac.css:1's monster oneliner
will break the responsive design. This is especially true when the logo is of different size.
Comment 2 Owen Leonard 2014-05-13 13:20:56 UTC
(In reply to Olli-Antti Kivilahti from comment #1)

> to overwrite the one in opac.css:1's monster oneliner
> will break the responsive design. This is especially true when the logo is
> of different size.

I recommend putting custom logos in the opacheader region if you're using the Bootstrap theme.
Comment 3 Owen Leonard 2014-07-01 16:47:39 UTC Comment hidden (obsolete)
Comment 4 Bernardo Gonzalez Kriegel 2014-07-03 13:03:49 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2014-07-03 14:31:00 UTC
Created attachment 29483 [details] [review]
[PASSED QA] Bug 11347 - PROG/CCSR deprecation: Remove opacsmallimage system-preference

The opacsmallimage system preference is unused in the bootstrap theme.
It can be removed now that prog and ccsr are deprecated. This patch does
so.

To test, apply the patch and run updatedatabase. Confirm that the OPAC
works properly and the preference can no longer be found.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Preference removed, no koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>