Bug 11351

Summary: Add support for SIP2 media types
Product: Koha Reporter: Kyle M Hall <kyle>
Component: SIP2Assignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: benjamin.rokseth, boutrosboutrosboutros, colin.campbell, gmcharlt, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 11351 - Add support for SIP2 media types
Bug 11351 - Add support for SIP2 media types
Bug 11351 - Add support for SIP2 media types
Bug 11351 - Add support for SIP2 media types
Bug 11351 - Add support for SIP2 media types [v3.12.06]
Rebased against master 2014-01-31
Tested according to described plan: - ran updatedatabase.pl - edited itemtype of book and added SIP media type book - restarted SIP server - made SIP request of book - verified that SIP media type returned CK001 (=book)
[PASSED QA] Bug 11351 - Add support for SIP2 media types
Bug 11351 - Add support for SIP2 media types - French file

Description Kyle M Hall 2013-12-06 18:35:25 UTC
Koha's SIP2 server implementation does not currently support the SIP2 protocol field "media type" ( CK ). It should.
Comment 1 Kyle M Hall 2013-12-06 18:38:36 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-12-06 18:41:10 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall 2013-12-06 19:25:50 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2013-12-09 13:23:46 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2013-12-09 13:42:00 UTC Comment hidden (obsolete)
Comment 6 Petter Goksøyr Åsen 2014-01-29 12:29:05 UTC
I'd like to test this, can you rebase?

Thanks
Comment 7 Benjamin Rokseth 2014-01-31 13:50:34 UTC Comment hidden (obsolete)
Comment 8 Benjamin Rokseth 2014-01-31 13:55:53 UTC Comment hidden (obsolete)
Comment 9 Martin Renvoize 2014-04-23 08:51:20 UTC
Created attachment 27453 [details] [review]
[PASSED QA] Bug 11351 - Add support for SIP2 media types

Koha's SIP2 server implementation does not currently support the SIP2
protocol field "media type" ( CK ).

This patch implements the SIP2 media type by allowing an arbitrary
mapping of itemtypes to SIP2 media types.

Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Edit an itemtype, select a SIP media type, and save the changes
4) Make a SIP2 Item Information Request
5) Verify that the CK field of the Item Information Response contains
   the correct media type code.

Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Martin Renvoize 2014-04-23 08:52:14 UTC
I'm happy this works as advertised, passes all qa tests and is a relatively trivial patch.
Comment 11 Jonathan Druart 2014-04-23 13:28:51 UTC
Created attachment 27476 [details] [review]
Bug 11351 - Add support for SIP2 media types - French file

This patch adds the SIP_MEDIA_TYPE AV for the fr-FR file.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 12 Galen Charlton 2014-04-28 18:25:18 UTC
Pushed to master.  Thanks, Kyle!