Summary: | C4::SQLHelper should be removed | ||
---|---|---|---|
Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
Component: | Architecture, internals, and plumbing | Assignee: | Yohann Dufour <yohann.dufour> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, katrin.fischer, kyle, m.de.rooy, tomascohen, yohann.dufour |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13440 | ||
Change sponsored?: | --- | Patch complexity: | Medium patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 12482, 12487, 12623, 12626, 12627, 12633 | ||
Bug Blocks: | 12608 | ||
Attachments: |
Bug 11385: SQLHelper removed
Bug 12633: Remove SQLHelper in C4::Members Bug 11385: Remove SQL::Helper [PASSED QA] Bug 11385: Remove SQL::Helper [SIGNED OFF] Bug 11385: Remove SQL::Helper [PASSED QA] Bug 11385: Remove SQL::Helper |
Description
Galen Charlton
2013-12-11 17:22:45 UTC
Created attachment 30201 [details] [review] Bug 11385: SQLHelper removed This patch removes the SQLHelper module, which has been replaced by DBIx::Class. Test plan : 1) Apply the patchs : - Contract : 12493 (UT), 12487 - Borrower::Modifications : 12623 - Acquisition : 12626 - Suggestions : 12445 (UT), 12627 - Members : 12457(UT), 12633 2) Verify there are no uses of SQLHelper with : git grep "SQLHelper" This depends on a report without patches in status Assigned. Moving status to BLOCKED Created attachment 37750 [details] [review] Bug 12633: Remove SQLHelper in C4::Members This is the only places where SQLHelper is still called. The C4::Members::Search is not used anymore, but ModMember and AddMember. This patch replaced the calls to SQLHelper to use DBIX::Class. TODO: Move them to Koha::Borrower. Test plan: 1/ Make sure the patron search still works (no changes expected since the code was not in used). 2/ Add a patron with all fields filled 3/ Add another patron with some fields filled 4/ Update them with other values 5/ Delete them You should not get any errors. Created attachment 37752 [details] [review] Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code. Created attachment 38699 [details] [review] [PASSED QA] Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 38700 [details] [review] [SIGNED OFF] Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 38944 [details] [review] [PASSED QA] Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Good job Jonathan! |