Bug 11385

Summary: C4::SQLHelper should be removed
Product: Koha Reporter: Galen Charlton <gmcharlt>
Component: Architecture, internals, and plumbingAssignee: Yohann Dufour <yohann.dufour>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: jonathan.druart, katrin.fischer, kyle, m.de.rooy, tomascohen, yohann.dufour
Version: master   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13440
Change sponsored?: --- Patch complexity: Medium patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 12482, 12487, 12623, 12626, 12627, 12633    
Bug Blocks: 12608    
Attachments: Bug 11385: SQLHelper removed
Bug 12633: Remove SQLHelper in C4::Members
Bug 11385: Remove SQL::Helper
[PASSED QA] Bug 11385: Remove SQL::Helper
[SIGNED OFF] Bug 11385: Remove SQL::Helper
[PASSED QA] Bug 11385: Remove SQL::Helper

Description Galen Charlton 2013-12-11 17:22:45 UTC
Now that DBIx::Class is integrated into Koha, C4::SQLHelper should be removed and replaced with use of DBIC.

Why?  Now that we have a real ORM, there is no need for a bespoke, imperfect DBMS abstraction module.

The following files reference C4::SQLHelper:

C4/Acquisition.pm
C4/Budgets.pm
C4/Contract.pm
C4/Members.pm
C4/SQLHelper.pm
C4/Suggestions.pm
Koha/Borrower/Modifications.pm
admin/aqbudgetperiods.pl
t/db_dependent/SQLHelper.t
Comment 1 Yohann Dufour 2014-07-28 12:31:17 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2015-03-19 08:31:19 UTC
This depends on a report without patches in status Assigned.
Moving status to BLOCKED
Comment 3 Jonathan Druart 2015-04-13 14:25:42 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2015-04-13 14:30:06 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2015-04-29 21:11:19 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2015-04-29 21:15:59 UTC Comment hidden (obsolete)
Comment 7 Kyle M Hall 2015-05-07 12:07:02 UTC
Created attachment 38944 [details] [review]
[PASSED QA] Bug 11385: Remove SQL::Helper

At this point, no occurrence of SQL::Helper should exist.
Let's remove the package and tests.

Test plan:
  git grep SQLHelper
and
  git grep InTable

Should not return anything in the Koha code.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 8 Tomás Cohen Arazi 2015-05-15 18:45:16 UTC
Patch pushed to master.

Good job Jonathan!