| Summary: | z39.50 searches not displaying errors | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Z39.50 / SRU / OpenSearch Servers | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, m.de.rooy, nblake, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 11419 - z39.50 searches not displaying errors
Bug 11419 - z39.50 searches not displaying errors [PASSED QA] Bug 11419 - z39.50 searches not displaying errors |
||
|
Description
Kyle M Hall (khall)
2013-12-18 19:41:55 UTC
Created attachment 23658 [details] [review] Bug 11419 - z39.50 searches not displaying errors When a z39.50 server isn't able to be searched successfully, the yellow error box comes up empty. Test Plan: 1) Go to Administration/z39.50 servers 2) Create a fake z39.50 server with a made up address 3) Go to cataloging, search only that server 4) Note the empty yellow alert box 5) Apply this patch 6) Re-run the search, not the alert box has a message in it now This patch looks good on our test system. It makes us happy and we'd like to approve it. Thanks, Nora Blake MassCat Created attachment 23719 [details] [review] Bug 11419 - z39.50 searches not displaying errors When a z39.50 server isn't able to be searched successfully, the yellow error box comes up empty. Test Plan: 1) Go to Administration/z39.50 servers 2) Create a fake z39.50 server with a made up address 3) Go to cataloging, search only that server 4) Note the empty yellow alert box 5) Apply this patch 6) Re-run the search, not the alert box has a message in it now Signed-off-by: Nora Blake <nblake@masslibsystem.org> I think the empty dialog box indicates some kind of bug, so changing this to 'minor' Created attachment 23821 [details] [review] [PASSED QA] Bug 11419 - z39.50 searches not displaying errors When a z39.50 server isn't able to be searched successfully, the yellow error box comes up empty. Test Plan: 1) Go to Administration/z39.50 servers 2) Create a fake z39.50 server with a made up address 3) Go to cataloging, search only that server 4) Note the empty yellow alert box 5) Apply this patch 6) Re-run the search, not the alert box has a message in it now Signed-off-by: Nora Blake <nblake@masslibsystem.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Works according to test plan. When one of the selected servers gives result no dialog box is shown before and after applying the patch. Thank you for your sign-off Nora! Pushed to master. Thanks, Kyle! Patch pushed to 3.14.x, will be in 3.14.2. This patch has been pushed to 3.12.x, will be in 3.12.11. Thanks Kyle! |