| Summary: | UT: XISBN.t returns failure | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> | 
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> | 
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> | 
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle, tomascohen | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: | Bug 11439: UT: XISBN.t returns failure Bug 11439: UT: Improve XISBN.t Bug 11439: UT: XISBN.t returns failure Bug 11439: UT: Improve XISBN.t Bug 11439: (follow up) add missing rollback call Bug 11439: (follow up) add missing rollback call Bug 11439: (follow up) add missing rollback call | ||
| 
        
          Description
        
        
          Jonathan Druart
        
        
        
        
          2013-12-24 09:07:31 UTC
        
       Created attachment 23801 [details] [review] Bug 11439: UT: XISBN.t returns failure A unit test fails in t/db_dependent/XISBN.t, the get_xisbn routine, if ThingISBN is enabled, returns the 3rd biblionumber, not the second one. Created attachment 23802 [details] [review] Bug 11439: UT: Improve XISBN.t The tests should be executed into a transaction and the SimpleSearch routine correctly mocked. Test plan: Verify that prove t/db_dependent/XISBN.t returns green. Created attachment 23822 [details] [review] Bug 11439: UT: XISBN.t returns failure A unit test fails in t/db_dependent/XISBN.t, the get_xisbn routine, if ThingISBN is enabled, returns the 3rd biblionumber, not the second one. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 23823 [details] [review] Bug 11439: UT: Improve XISBN.t The tests should be executed into a transaction and the SimpleSearch routine correctly mocked. Test plan: Verify that prove t/db_dependent/XISBN.t returns green. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I'm making an exception from normal QA policy and pushing this directly to master. Thanks, Jonathan! Created attachment 24104 [details] [review] Bug 11439: (follow up) add missing rollback call This UT got wrapped inside a transaction with autocommit=0 but the rollback call was inadvertedly ommited. Adding it. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Hi Tomás, The rollback is not necessary when put at the end. Some others UT files don't execute the rollback (explicitly). I will sign off your patch but I am not sure it is essential. Created attachment 24112 [details] [review] Bug 11439: (follow up) add missing rollback call This UT got wrapped inside a transaction with autocommit=0 but the rollback call was inadvertedly ommited. Adding it. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 24129 [details] [review] Bug 11439: (follow up) add missing rollback call This UT got wrapped inside a transaction with autocommit=0 but the rollback call was inadvertedly ommited. Adding it. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed the follow-up to master. Thanks, Tomás! Patches pushed to 3.14.x, will be in 3.14.2. I have taken the liberty of pushing another follow-up to account for a change in the list of ISBNs returned by OCLC's XISBN service. Setting status back to pushed to master; I recommend that RMaints pick up this follow-up ASAP. 4th patch pushed to 3.14.x, will be in 3.14.4. |