| Summary: | t/db_dependent/Bookseller.t can fail when subscription table is not empty | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Test Suite | Assignee: | Chris Cormack <chris> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers |
| Version: | 3.14 | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: |
Bug 11457 : Clearing subscription table so tests pass correctly
[SIGNED OFF] Bug 11457 : Clearing subscription table so tests pass correctly Bug 11457 : Clearing subscription table so tests pass correctly |
||
|
Description
Katrin Fischer
2013-12-29 21:11:15 UTC
Yep, if you have an old subscription that ended before 2013-12-31 test 22 will fail. If one is older than 2013-08-15 23 will also fail. Created attachment 23886 [details] [review] Bug 11457 : Clearing subscription table so tests pass correctly To test 1/ Add a subscription in the serials module, with an end date before 2013-08-01 2/ run prove -v t/db_dependent/Bookseller.t Notice tests 22 and 23 fail 3/ Apply patch 4/ run test again 5/ Notice tests succeed Created attachment 23890 [details] [review] [SIGNED OFF] Bug 11457 : Clearing subscription table so tests pass correctly To test 1/ Add a subscription in the serials module, with an end date before 2013-08-01 2/ run prove -v t/db_dependent/Bookseller.t Notice tests 22 and 23 fail 3/ Apply patch 4/ run test again 5/ Notice tests succeed Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests now clean the subscription table before running the tests, so that the will always pass. Created attachment 24100 [details] [review] Bug 11457 : Clearing subscription table so tests pass correctly To test 1/ Add a subscription in the serials module, with an end date before 2013-08-01 2/ run prove -v t/db_dependent/Bookseller.t Notice tests 22 and 23 fail 3/ Apply patch 4/ run test again 5/ Notice tests succeed Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests now clean the subscription table before running the tests, so that the will always pass. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Chris! Patch pushed to 3.14.x, will be in 3.14.4. |