Summary: | Circulation_transfers.t can fail, spuriously | ||
---|---|---|---|
Product: | Koha | Reporter: | Galen Charlton <gmcharlt> |
Component: | Test Suite | Assignee: | Chris Cormack <chris> |
Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11470: fix occassional spurious test failure in Circulation_transfers.t
Bug 11470: fix occassional spurious test failure in Circulation_transfers.t [PASSED QA] Bug 11470: fix occassional spurious test failure in Circulation_transfers.t [PASSED QA] Bug 11470: fix occassional spurious test failure in Circulation_transfers.t |
Description
Galen Charlton
2014-01-02 18:01:58 UTC
Created attachment 23895 [details] [review] Bug 11470: fix occassional spurious test failure in Circulation_transfers.t This patch makes Circulation_transfers.t no longer be sensitive to the exact time it runs, avoiding spurious test failures due to datesent being a second off between the creation of the test transfer and the comparison. To test: [1] To simulate the failure, add a "sleep(2);" after the "#Test GetTransfers" comment and run prove -v t/db_dependent/Circulation_transfers.t [2] Remove the sleep and apply the patch. [3] Verify that prove -v t/db_dependent/Circulation_transfers.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 23903 [details] [review] Bug 11470: fix occassional spurious test failure in Circulation_transfers.t This patch makes Circulation_transfers.t no longer be sensitive to the exact time it runs, avoiding spurious test failures due to datesent being a second off between the creation of the test transfer and the comparison. To test: [1] To simulate the failure, add a "sleep(2);" after the "#Test GetTransfers" comment and run prove -v t/db_dependent/Circulation_transfers.t [2] Remove the sleep and apply the patch. [3] Verify that prove -v t/db_dependent/Circulation_transfers.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 23908 [details] [review] [PASSED QA] Bug 11470: fix occassional spurious test failure in Circulation_transfers.t This patch makes Circulation_transfers.t no longer be sensitive to the exact time it runs, avoiding spurious test failures due to datesent being a second off between the creation of the test transfer and the comparison. To test: [1] To simulate the failure, add a "sleep(2);" after the "#Test GetTransfers" comment and run prove -v t/db_dependent/Circulation_transfers.t [2] Remove the sleep and apply the patch. [3] Verify that prove -v t/db_dependent/Circulation_transfers.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. Created attachment 23909 [details] [review] [PASSED QA] Bug 11470: fix occassional spurious test failure in Circulation_transfers.t This patch makes Circulation_transfers.t no longer be sensitive to the exact time it runs, avoiding spurious test failures due to datesent being a second off between the creation of the test transfer and the comparison. To test: [1] To simulate the failure, add a "sleep(2);" after the "#Test GetTransfers" comment and run prove -v t/db_dependent/Circulation_transfers.t [2] Remove the sleep and apply the patch. [3] Verify that prove -v t/db_dependent/Circulation_transfers.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. Pushed to master. Patch pushed to 3.14.x, will be in 3.14.4. |