| Summary: | Remove experimental given/when from C4::Utils::Datatables | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
| Component: | Architecture, internals, and plumbing | Assignee: | Colin Campbell <colin.campbell> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Proposed Patch
Bug 11474: Remove errors caused by use of switch [PASSED QA] Bug 11474: Remove errors caused by use of switch |
||
|
Description
Colin Campbell
2014-01-03 10:46:22 UTC
Created attachment 23899 [details] [review] Proposed Patch Created attachment 23906 [details] [review] Bug 11474: Remove errors caused by use of switch Have replaced a switch statement by an if so we do not get warnings on compilation Note the perldoc for the subroutine was not correct code was not testing that paramater equalled the values but that it contained them. Have amended accordingly Have documented behaviour in case parameter contains neither value. subroutine does not appear to me used elsewhere in codebase Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 23913 [details] [review] [PASSED QA] Bug 11474: Remove errors caused by use of switch Have replaced a switch statement by an if so we do not get warnings on compilation Note the perldoc for the subroutine was not correct code was not testing that paramater equalled the values but that it contained them. Have amended accordingly Have documented behaviour in case parameter contains neither value. subroutine does not appear to me used elsewhere in codebase Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, especially t/DateUtils.t. Pushed to master. Thanks, Colin! |