Summary: | Remove experimental given/when from Koha::SimpleMARC | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Architecture, internals, and plumbing | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed Patch
Bug 11478 Replace experimental given/when keywords Bug 11478 Replace experimental given/when keywords |
Description
Colin Campbell
2014-01-06 11:50:28 UTC
Created attachment 23929 [details] [review] Proposed Patch With patch applied module will not issue errors because of use of experimental features in testsuite with perl >= 5.18 Created attachment 25355 [details] [review] Bug 11478 Replace experimental given/when keywords The keywords given and when are flagged experimental in perl 5.18 and subject to change replace the construct by an if/elsif Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Same as bug 11479 comment 3, it is for/when, not given/when. Created attachment 25498 [details] [review] Bug 11478 Replace experimental given/when keywords The keywords given and when are flagged experimental in perl 5.18 and subject to change replace the construct by an if/elsif Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master. Thanks, Colin! Pushed to 3.14.x, will be in 3.14.07 |