Summary: | new reservation syspref HoldOnlyWhenAllItemsOnLoan | ||
---|---|---|---|
Product: | Koha | Reporter: | Koha Team University Lyon 3 <koha> |
Component: | OPAC | Assignee: | Koha Team University Lyon 3 <koha> |
Status: | CLOSED WORKSFORME | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aurelie.fichot, jean-manuel.broust, josef.moravec, koha, marjorie.barry-vila, nengard, nmichot |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9190 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 11482 | ||
Attachments: |
Bug-11481-HoldOnlyWhenAllItemsOnLoan-new-syspref.patch
Bug 11481 HoldOnlyWhenAllItemsOnLoan new syspref Bug 11481 HoldOnlyWhenAllItemsOnLoan new syspref |
Description
Koha Team University Lyon 3
2014-01-06 17:23:10 UTC
Created attachment 23974 [details] [review] Bug-11481-HoldOnlyWhenAllItemsOnLoan-new-syspref.patch I do the test plan but I always see the Place hold button... :-(((( Created attachment 24397 [details] [review] Bug 11481 HoldOnlyWhenAllItemsOnLoan new syspref "Place hold" button works now as described. <h1>Something went wrong !</h1>Applying: Bug 11481 HoldOnlyWhenAllItemsOnLoan new syspref Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Reserves.pm Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging opac/opac-detail.pl Auto-merging reserve/request.pl Failed to merge in the changes. Patch failed at 0001 Bug 11481 HoldOnlyWhenAllItemsOnLoan new syspref When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11481 - new reservation syspref HoldOnlyWhenAllItemsOnLoan 24397 - Bug 11481 HoldOnlyWhenAllItemsOnLoan new syspref Created attachment 26112 [details] [review] Bug 11481 HoldOnlyWhenAllItemsOnLoan new syspref patch rebased Tests done today on sandbox : It seems Ok when there is only one item type on the the same record : 1 item available + 1 item on a notforloan statu = Opac : no hold button (when patron is authentificated) = Staff : Alert message ( with possibility to overstep) but wrong text « Cannot place hold : to many holds ») 1 item On loan + 1 item on a notforloan statu = Opac : hold button (when patron is authentificated) = Staff : hold OK 1 item available + 1 item on a notforloan statu + 1 item lost = Opac : no hold button (when patron is authentificated) = Staff : Alert message ( with possibility to overstep) but wrong text « Cannot place hold : to many holds ») 1 item on a notforloan statu + 1 item lost = Opac : no hold button (when patron is authentificated) = Staff : No alert message ( with possibility to overstep) 1 item available in another library + 1 item on a notforloan statu = Opac : no hold button (when patron is authentificated) = Staff : Alert message ( with possibility to overstep) but wrong text « Cannot place hold : to many holds ») 1 item available in transfer + 1 item on a notforloan statu = Opac : no hold button (when patron is authentificated) = Staff : Staff : Alert message ( with possibility to overstep) but wrong text « Cannot place hold : to many holds ») When there is 2 different itemtypes on the same record, one of which with a circ rule without holds allowed : - 1 item available (with holds allowed) + 1 item available (with NO holds allowed) = Opac : no hold button (when patron is authentificated) = Staff : 2 Alert messages( with possibility to overstep) : one with wrong text « Cannot place hold : to many holds ») + one with good text « All reservable items of the record must be on loan » - 1 item on loan (with holds allowed) + 1 item available (with NO holds allowed) = Opac : no hold button (when patron is authentificated) ERROR : patron could hold cause the only item hold allowed is on loan = Staff : 2 Alert messages( with possibility to overstep) : one with wrong text « Cannot place hold : to many holds ») + one with good text « All reservable items of the record must be on loan » Conclusion : we don't sign off because of the last case (In reply to michot from comment #6) > Tests done today on sandbox : > > It seems Ok when there is only one item type on the the same record : > > 1 item available + 1 item on a notforloan statu > = Opac : no hold button (when patron is authentificated) > = Staff : Alert message ( with possibility to overstep) but wrong text « > Cannot place hold : to many holds ») > > 1 item On loan + 1 item on a notforloan statu > = Opac : hold button (when patron is authentificated) > = Staff : hold OK > > 1 item available + 1 item on a notforloan statu + 1 item lost > = Opac : no hold button (when patron is authentificated) > = Staff : Alert message ( with possibility to overstep) but wrong text « > Cannot place hold : to many holds ») > > 1 item on a notforloan statu + 1 item lost > = Opac : no hold button (when patron is authentificated) > = Staff : No alert message ( with possibility to overstep) > > 1 item available in another library + 1 item on a notforloan statu > = Opac : no hold button (when patron is authentificated) > = Staff : Alert message ( with possibility to overstep) but wrong text « > Cannot place hold : to many holds ») > > 1 item available in transfer + 1 item on a notforloan statu > = Opac : no hold button (when patron is authentificated) > = Staff : Staff : Alert message ( with possibility to overstep) but wrong > text « Cannot place hold : to many holds ») > > > When there is 2 different itemtypes on the same record, one of which with a > circ rule without holds allowed : > - 1 item available (with holds allowed) + 1 item available (with NO holds > allowed) > = Opac : no hold button (when patron is authentificated) > = Staff : 2 Alert messages( with possibility to overstep) : one with wrong > text « Cannot place hold : to many holds ») + one with good text « All > reservable items of the record must be on loan » > > - 1 item on loan (with holds allowed) + 1 item available (with NO holds > allowed) > = Opac : no hold button (when patron is authentificated) > ERROR : patron could hold cause the only item hold allowed is on loan > = Staff : 2 Alert messages( with possibility to overstep) : one with wrong > text « Cannot place hold : to many holds ») + one with good text « All > reservable items of the record must be on loan » > > > > Conclusion : we don't sign off because of the last case Can you give more details about the hold rules (hold for all libraries, ( rule for a specific library, hold policy for such library, holds policy by item ? ) and the level of itype (syspref item-level_itypes) you applied for your test because I don't get this error in my tests. Olivier Crouzet Sorry but I don't accede to any sandbox, so i can't look at the rules I drop this patch. We have this functionality - it can be set up on circulation rules page |