Bug 11484

Summary: Add option to purge z39.50 search records from import table to cleanup_database.pl
Product: Koha Reporter: Kyle M Hall (khall) <kyle>
Component: Command-line UtilitiesAssignee: Kyle M Hall (khall) <kyle>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, gmcharlt, jonathan.druart, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl
Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl
Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl

Description Kyle M Hall (khall) 2014-01-06 18:45:45 UTC
It would be good to be able to specifically target import records from z39.50 for cleanup.
Comment 1 Kyle M Hall (khall) 2014-01-06 18:47:51 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-03-04 11:21:12 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2014-04-17 06:59:59 UTC
Created attachment 27226 [details] [review]
Bug 11484 - Add option to purge z39.50 search records from import table to cleanup_database.pl

It would be good to be able to specifically target import records from
z39.50 for cleanup.

Test Plan:
1) Apply this patch
2) Import one or more batch record sets into Koha
3) Perform some z39.50 searches
4) Run this command: misc/cronjobs/cleanup_database.pl -v --z3950
5) Verify that only z39.50 records were deleted

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2014-04-17 07:02:57 UTC
QA Comment:
Code looks good to me. No complaints from qa tools.
Bonus points for follow-ups adding options for selectively removing z3950 records based on number of days (as in some other options) or printing the number of removed records with verbose.

Passed QA
Comment 5 Galen Charlton 2014-04-17 16:39:28 UTC
Pushed to master.  Thanks, Kyle!
Comment 6 Fridolin Somers 2014-08-06 09:46:02 UTC
Pushed to 3.14.x, will be in 3.14.10