| Summary: | Untranslatable tooltip "Dates of birth should be entered in the format ..." | ||
|---|---|---|---|
| Product: | Koha | Reporter: | paxed <pasi.kallinen> |
| Component: | I18N/L10N | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | aleisha, bgkriegel, chris, f.demians, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | Bug 11487: Untranslatable tooltip "Dates of birth should be entered in the format ..." | ||
|
Description
paxed
2014-01-07 12:30:26 UTC
Created attachment 24322 [details] [review] Bug 11487: Untranslatable tooltip "Dates of birth should be entered in the format ..." Test plan: 1. Test that tooltip still shows 2. We couldn't test the translations so please can someone else test it? I really don't know why but this patch does not work. After applying it: ./translate update fr-FR I don't find the string in the po file. Marked as Failed QA. I suggest:
var dob = _("Dates of birth should be entered in this format:")+ " '"+[% format %]+"'";
...and note that my comment on Bug 11488 about tab indentation is true of this patch as well.
Ditto on the translation test step.
(In reply to Owen Leonard from comment #4) > I suggest: > > var dob = _("Dates of birth should be entered in this format:")+ " '"+[% > format %]+"'"; > > ...and note that my comment on Bug 11488 about tab indentation is true of > this patch as well. > > Ditto on the translation test step. Please do not advocate hard-coding the placement of placeholders, it makes translation harder. (In reply to paxed from comment #5) > Please do not advocate hard-coding the placement of placeholders, it makes > translation harder. If you would like to convince me, please don't criticize without providing an explanation. Help me understand rather than just telling me I'm wrong. Since the strings are currently not translatable, Owen's proposition seems to be a good compromise. This bug is proving to be quite the instruction for the high school students. Mostly in how not to communicate if you want someone to work on your fix. Thanks Owen and Jonathan for bringing it back. |