Summary: | The number of tested records when searching for duplicates during import is too low | ||
---|---|---|---|
Product: | Koha | Reporter: | Matthias Meusburger <matthias.meusburger> |
Component: | Cataloging | Assignee: | Matthias Meusburger <matthias.meusburger> |
Status: | ASSIGNED --- | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, liz, m.de.rooy, mtompset |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
proposed patch
Bug 11496: Raise number of tested records when searching for duplicate during import. |
Description
Matthias Meusburger
2014-01-08 09:38:29 UTC
Created attachment 24006 [details] [review] proposed patch Please note that this is a naive implementation of the fix (I've arbitrarily raised the matching records from 10 to 1000). If you agree that this is an issue, a better patch with a configurable amount of records to search might be proposed. Couldn't we have logic that knows about tighter matches (ISBN) vs. less precise matches (authors)? And for the less precise ones, couldn't even 1000 still fail? There is no need amha to implement such logic, because for tighter matches, even if the limit is high, only a few results will be returned. ie: having a limit of 1000 will not slow down things for isbn, because only a few isbn's will be returned. We can safely have a high limit even for tighter matches. As for your second point, 1000 could possibly fail, but very less likely than with 10. Created attachment 37626 [details] [review] Bug 11496: Raise number of tested records when searching for duplicate during import. - Previously, only the first 10 records returned by koha for a given matchpoint were tested. This is not enough in many cases, because a significant matching record can be beyond these 10 first results. This patch raise the search to 1000 records, for more accurate, but slower results. Rescued this from a 'Patch Does Not Apply' situation. Also, please provide a test plan. This needs a test plan please, before we can test it. Should this be 'Needs signoff'? |