|
Description
Tomás Cohen Arazi (tcohen)
2014-01-08 15:17:04 UTC
Created attachment 24014 [details] [review] Bug 11499 - (regression tests) indexing modes not properly set on generated koha-conf.xml t/db_dependent/Search.t creates its own temporary koha-conf.xml and related files, and it fails to properly set indexing modes for bibliographic and authority records. This patch adds regression tests for that. To test: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 To+ Sponsored-by: Universidad Nacional de Cordoba Created attachment 24015 [details] [review] Bug 11499 - Make zebra_setup.pl correctly set indexing mode By adding the relevant environment variables to the script the generated koha-conf.xml file for the unit tests is correct now. Test plan: - Verify that tests pass now: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 Regards To+ Sponsored-by: Universidad Nacional de Cordoba Created attachment 24021 [details] [review] Bug 11499: (regression tests) indexing modes not properly set on generated koha-conf.xml t/db_dependent/Search.t creates its own temporary koha-conf.xml and related files, and it fails to properly set indexing modes for bibliographic and authority records. This patch adds regression tests for that. To test: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 The test should fail unless the main page is applied. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 24022 [details] [review] Bug 11499: UT: Make zebra_setup.pl correctly set indexing mode By adding the relevant environment variables to the script the generated koha-conf.xml file for the unit tests is correct now. Test plan: - Verify that tests pass now: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 24122 [details] [review] Bug 11499: (regression tests) indexing modes not properly set on generated koha-conf.xml t/db_dependent/Search.t creates its own temporary koha-conf.xml and related files, and it fails to properly set indexing modes for bibliographic and authority records. This patch adds regression tests for that. To test: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 The test should fail unless the main page is applied. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 24123 [details] [review] Bug 11499: UT: Make zebra_setup.pl correctly set indexing mode By adding the relevant environment variables to the script the generated koha-conf.xml file for the unit tests is correct now. Test plan: - Verify that tests pass now: $ prove -v t/db_dependent/Search.t 2> /dev/null | grep 11499 Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes unit test, koha-qa.pl Pushed to master. Thanks, Tomás! Patches pushed to 3.14.x, will be in 3.14.4. |