Bug 11516

Summary: OPAC highlight lost in results browser
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, kyle, sandboxes
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 11516 - OPAC highlight lost in results browser
Bug 11516 - OPAC highlight lost in results browser
Bug 11516 - OPAC highlight lost in results browser
Bug 11516 - OPAC highlight lost in results browser

Description Fridolin Somers 2014-01-10 11:44:51 UTC
When OpacHighlightedWords syspref is on, the current search terms are highlighted in results and detail pages.
This workes in detail page with the URL param 'query_desc'.
This parameter must be managed in results browser (appears when OpacBrowseResults syspref is on) links.
Comment 1 Fridolin Somers 2014-01-10 12:04:19 UTC Comment hidden (obsolete)
Comment 2 Fridolin Somers 2014-01-10 12:16:53 UTC Comment hidden (obsolete)
Comment 3 Biblibre Sandboxes 2014-01-10 15:28:11 UTC
Patch tested with a sandbox, by Aurélie <aurelie.fichot@gmail.com>
Comment 4 Biblibre Sandboxes 2014-01-10 15:28:31 UTC Comment hidden (obsolete)
Comment 5 Aurélie Fichot 2014-01-10 15:31:01 UTC
YES !
The current search terms are highlighted in results and detail pages (but not in the "Browse results" but perhaps it's normal...).
Comment 6 Kyle M Hall (khall) 2014-01-10 15:58:48 UTC
The choice to "unhighlight" search terms is not remembered when moving between pages. If this is not an issue, please reset status to "Signed off".
Comment 7 Fridolin Somers 2014-01-13 07:53:28 UTC
(In reply to Kyle M Hall from comment #6)
> The choice to "unhighlight" search terms is not remembered when moving
> between pages. If this is not an issue, please reset status to "Signed off".
The "Unhighlight" link is a JavaScript function. I think it is used only some times to maybe have a clearer look at record datas.
So in my opinion, this choice should not be remembered when moving to another result.
Note that in results page, "unhighlight" choice is not remembered when moving to another results page.

(but not in the "Browse results" but perhaps it's normal...).(In reply to Aurélie Fichot from comment #5)
> but not in the "Browse results" but perhaps it's normal...
It is normal. It would be to much highlight in my opinion.
Comment 8 Kyle M Hall (khall) 2014-01-17 15:38:24 UTC
Created attachment 24512 [details] [review]
Bug 11516 - OPAC highlight lost in results browser
Comment 9 Galen Charlton 2014-03-10 21:32:15 UTC
Pushed to master.  Thanks, Fridolin!

I should point out one edit in particular I made to the commit message: I removed the statement that highlighting does not work when using XSLT -- it works for me.
Comment 10 Fridolin Somers 2014-05-27 14:45:03 UTC
Pushed to 3.14.x, will be in 3.14.07