Summary: | self registration formatting | ||
---|---|---|---|
Product: | Koha | Reporter: | Christopher Brannon <cbrannon> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | francescalamoore, fridolin.somers, gmcharlt, jonathan.druart, kyle, wizzyrea |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
"Required" text out of place.
Out of place empty paragraph. bug 11522 self-registration formating Bug 11522 self-registration formating Bug 11522 self-registration formating |
Created attachment 24184 [details]
Out of place empty paragraph.
Flagged for Catalyst Academy, if worse comes to worse. Created attachment 24324 [details] [review] bug 11522 self-registration formating 1. in prog theme, enable opac self-registration and inspect clear date with firebug note that there are empty paragraph tags 2. add date of birth as a requirment in self-registration 3. apply patch 4. refresh page and notice that empty paragraph tags have been deleted, so that required lines up with clear date 5. repeat the above steps for bootstrap theme Created attachment 24408 [details] [review] Bug 11522 self-registration formating 1. in prog theme, enable opac self-registration and inspect clear date with firebug note that there are empty paragraph tags 2. add date of birth as a requirment in self-registration 3. apply patch 4. refresh page and notice that empty paragraph tags have been deleted, so that required lines up with clear date 5. repeat the above steps for bootstrap theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 24414 [details] [review] Bug 11522 self-registration formating 1. in prog theme, enable opac self-registration and inspect clear date with firebug note that there are empty paragraph tags 2. add date of birth as a requirment in self-registration 3. apply patch 4. refresh page and notice that empty paragraph tags have been deleted, so that required lines up with clear date 5. repeat the above steps for bootstrap theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Simple patch. It works for prog and bootstrap. Pushed to master. Congratulations on having your first patch accepted into Koha, Francesca! Patch pushed to 3.14.x, will be in 3.14.5 Patch pushed to 3.12.x, will be in 3.12.13 |
Created attachment 24183 [details] "Required" text out of place. If you require a birth date in self registration, the red "Required" text appears below and to the left, instead of to the right of the required element. (see attachment) Looking in firebug, it appears there are empty paragraph marks. If these were to be removed, placement should be restored. (see attachment) Christopher