Bug 11531

Summary: Cannot add new libraries to the transport cost if previously used.
Product: Koha Reporter: Kyle M Hall <kyle>
Component: Hold requestsAssignee: Kyle M Hall <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, gmcharlt
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 11531 - Cannot add new libraries to the transport cost if previously used.
Bug 11531 - Cannot add new libraries to the transport cost if previously used.
[PASSED QA] Bug 11531 - Cannot add new libraries to the transport cost if previously used.

Description Kyle M Hall 2014-01-13 17:34:09 UTC
If you are using the transport cost matrix, and you create a new library, you cannot edit the fields for this library!

To reproduce:
1) Enable the transport cost matrix
2) Set some transport cost values in the matrix
3) Save the matrix
4) Create a new library
5) View the transport cost matrix again
6) Note the uneditable fields for the new branch

Cause:
The transport cost matrix assumes either every library is in the transport_matrix table, or that no libraries are in it.
Comment 1 Kyle M Hall 2014-01-13 17:42:06 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-03-04 11:11:22 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-03-12 17:42:52 UTC
Created attachment 26207 [details] [review]
[PASSED QA] Bug 11531 - Cannot add new libraries to the transport cost if previously used.

If you are using the transport cost matrix, and you create a new library, you cannot edit the fields for this library!

Test Plan:
1) Enable the transport cost matrix
2) Set some transport cost values in the matrix
3) Save the matrix
4) Create a new library
5) View the transport cost matrix again
6) Note the uneditable fields for the new branch
7) Apply this patch
8) View the transport cost matrix again
9) Note you can now edit the fields for the new branch

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests and QA script.
Comment 4 Galen Charlton 2014-03-12 18:02:52 UTC
Pushed to master.  Thanks, Kyle!
Comment 5 Fridolin Somers 2014-06-12 07:19:59 UTC
Pushed to 3.14.x, will be in 3.14.08
Comment 6 Kyle M Hall 2014-06-13 12:29:32 UTC
Pushed to 3.12.x, will be in 3.12.13