| Summary: | Increasing test coverage for C4::Charset | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Emma Heath <emmaheath.student> |
| Component: | Test Suite | Assignee: | Chris Cormack <chris> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Proposed patch
Bug:11540 increasing coverage of Charset.pm Bug:11540 increasing coverage of Charset.pm [SIGNED-OFF] Bug 11540: increasing coverage of Charset.pm Bug 11540: (folowup) add a couple of tests more Bug 11540: increasing coverage of Charset.pm Bug 11540: (folowup) add a couple of tests more [PASSED QA] Bug 11540: increasing coverage of Charset.pm [PASSED QA] Bug 11540: (folowup) add a couple of tests more |
||
|
Description
Emma Heath
2014-01-14 01:14:13 UTC
Created attachment 24251 [details] [review] Proposed patch Created attachment 24263 [details] [review] Bug:11540 increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run Created attachment 24266 [details] [review] Bug:11540 increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run Signed-off-by: Tom Houlker <thomas.houlker@hibs.school.nz> Created attachment 24285 [details] [review] [SIGNED-OFF] Bug 11540: increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run Signed-off-by: Tom Houlker <thomas.houlker@hibs.school.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Created attachment 24286 [details] [review] Bug 11540: (folowup) add a couple of tests more This patch makes sure all scenarios are covered for SetUTF8Flag. Regards To+ Created attachment 24304 [details] [review] Bug 11540: increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run Signed-off-by: Tom Houlker <thomas.houlker@hibs.school.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Created attachment 24307 [details] [review] Bug 11540: (folowup) add a couple of tests more This patch makes sure all scenarios are covered for SetUTF8Flag. Regards To+ Signed-off-by: Emma Heath <emmaheath.student@wegc.school.nz> Created attachment 24316 [details] [review] [PASSED QA] Bug 11540: increasing coverage of Charset.pm To test 1. run prove t/Charset.t 2. apply patch 3. run prove t/Charset.t notice more tests are run Signed-off-by: Tom Houlker <thomas.houlker@hibs.school.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests pass! Created attachment 24317 [details] [review] [PASSED QA] Bug 11540: (folowup) add a couple of tests more This patch makes sure all scenarios are covered for SetUTF8Flag. Regards To+ Signed-off-by: Emma Heath <emmaheath.student@wegc.school.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Pushed to master. Congratulations on having your first patch accepted to Koha, Emma! This patch has been pushed to 3.12.x, will be in 3.12.11. Thanks and congratulations Emma! |