| Summary: | Increasing test coverage for C4::Languages | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Merllissia Manueli <manuelimel> |
| Component: | Test Suite | Assignee: | Chris Cormack <chris> |
| Status: | CLOSED FIXED | QA Contact: | Galen Charlton <gmcharlt> |
| Severity: | enhancement | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Proposed Patch
bug 11545 Increasing test coverage for Languages.pm To test 1. Run prove t/Languages.t Apply patch 2. Run prove t/Languages.t Notice: More tests are run [SIGNED-OFF] bug 11545 Increasing test coverage for Languages.pm [PASSED QA] bug 11545 Increasing test coverage for Languages.pm |
||
|
Description
Merllissia Manueli
2014-01-14 01:16:15 UTC
Created attachment 24254 [details] [review] Proposed Patch Created attachment 24260 [details] [review] bug 11545 Increasing test coverage for Languages.pm To test 1. Run prove t/Languages.t Apply patch 2. Run prove t/Languages.t Notice: More tests are run Signed-off-by: alex_h <dhorsman@xtra.co.nz> Created attachment 24298 [details] [review] [SIGNED-OFF] bug 11545 Increasing test coverage for Languages.pm To test 1. Run prove t/Languages.t Apply patch 2. Run prove t/Languages.t Notice: More tests are run Signed-off-by: alex_h <dhorsman@xtra.co.nz> Signed-off-by: Magnus Enger <magnus@enger.priv.no> Adds another passing test. I took th liberty of moving the test plan from the subject to the commit message. :-) Created attachment 24308 [details] [review] [PASSED QA] bug 11545 Increasing test coverage for Languages.pm To test 1. Run prove t/Languages.t Apply patch 2. Run prove t/Languages.t Notice: More tests are run Signed-off-by: alex_h <dhorsman@xtra.co.nz> Signed-off-by: Magnus Enger <magnus@enger.priv.no> Adds another passing test. I took th liberty of moving the test plan from the subject to the commit message. :-) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tests pass :) Pushed to master, along with a follow-up that moves Languages.t to t/db_dependent. That signals that the test script requires that there be a Koha database to connect to, as is required in order to test getAllLanguages(). Congratulations on having your first patch accepted into Koha, Merllissia! |