| Summary: | facets labels are not css selectable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Francesca <francescalamoore> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, chris, dcook, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
propose patch
bug 11546 facets labels are not css selectable bug 11546 facets labels are not css selectable |
||
|
Description
Francesca
2014-01-14 01:44:31 UTC
Created attachment 24256 [details] [review] propose patch Created attachment 24262 [details] [review] bug 11546 facets labels are not css selectable To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Created attachment 24269 [details] [review] bug 11546 facets labels are not css selectable To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. I'm not sure that this change is necessary, since the parent li elements have IDs that can be hooked onto for CSS, but it doesn't change existing behaviour and more control is always nice, so that's all right. I create a patch for that in bug 11312. *** This bug has been marked as a duplicate of bug 11312 *** Francesca, Perhaps you could test Jonathan's patch on bug 11312, and sign off on that. Which I'm sure Jonathan would appreciate. And we will find a new bug to get your first patch into Koha. |