| Summary: | Add a couple of unit tests for C4::Acq::GetOrder | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, matted-34813 |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10789 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 11550: GetOrder always returns a non empty hashref
Bug 11550: Add UT for C4::Acquisition::GetOrder Bug 11550: Add UT for C4::Acquisition::GetOrder Bug 11550: Add UT for C4::Acquisition::GetOrder [PASSED QA] Bug 11550: Add UT for C4::Acquisition::GetOrder [PASSED QA] Bug 11550: Add UT for C4::Acquisition::GetOrder [PASSED QA] Bug 11550: Add UT for C4::Acquisition::GetOrder |
||
|
Description
Jonathan Druart
2014-01-14 11:21:34 UTC
Created attachment 24277 [details] [review] Bug 11550: GetOrder always returns a non empty hashref If GetOrder is called with a nonexistent ordernumber or without any ordernumber, it should return undef. Test plan: prove t/db_dependent/Acquisition.t Can you rebase. Got merge conflicts, and I'll try again. - wajasu Created attachment 25686 [details] [review] Bug 11550: Add UT for C4::Acquisition::GetOrder If GetOrder is called with a nonexistent ordernumber or without any ordernumber, it should return undef. Test plan: prove t/db_dependent/Acquisition.t The concern of this patch has been fixed by bug 10789. I think we could keep the unit tests. Created attachment 25955 [details] [review] Bug 11550: Add UT for C4::Acquisition::GetOrder If GetOrder is called with a nonexistent ordernumber or without any ordernumber, it should return undef. Test plan: prove t/db_dependent/Acquisition.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch doesn't apply and I think it needs some refactoring with the recent changes to Acquisition.t Created attachment 26124 [details] [review] Bug 11550: Add UT for C4::Acquisition::GetOrder If GetOrder is called with a nonexistent ordernumber or without any ordernumber, it should return undef. Test plan: prove t/db_dependent/Acquisition.t Created attachment 26144 [details] [review] [PASSED QA] Bug 11550: Add UT for C4::Acquisition::GetOrder If GetOrder is called with a nonexistent ordernumber or without any ordernumber, it should return undef. Test plan: prove t/db_dependent/Acquisition.t Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Updated number of tests to 68, tests and QA script all happy now. Looked at a few pages in aquisition using GetOrder as well. Created attachment 26145 [details] [review] [PASSED QA] Bug 11550: Add UT for C4::Acquisition::GetOrder If GetOrder is called with a nonexistent ordernumber or without any ordernumber, it should return undef. Test plan: prove t/db_dependent/Acquisition.t Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Updated number of tests to 68, tests and QA script all happy now. Looked at a few pages in aquisition using GetOrder as well. Created attachment 26146 [details] [review] [PASSED QA] Bug 11550: Add UT for C4::Acquisition::GetOrder If GetOrder is called with a nonexistent ordernumber or without any ordernumber, it should return undef. Test plan: prove t/db_dependent/Acquisition.t Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Updated number of tests to 68, tests and QA script all happy now. Looked at a few pages in aquisition using GetOrder as well. Pushed to master. Thanks, Jonathan! Pushed to 3.14.x, will be in 3.14.08 |