Bug 11561

Summary: Preventing duplicate print notices and enforcing a print notice if no notices can be generated
Product: Koha Reporter: Olli-Antti Kivilahti <olli-antti.kivilahti>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, jonathan.druart, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 10845    
Bug Blocks:    
Attachments: Bug 11561: Preventing duplicate print notices and enforcing a print notice if no notices can be generated

Description Olli-Antti Kivilahti 2014-01-15 15:08:20 UTC

    
Comment 1 Olli-Antti Kivilahti 2014-01-15 15:09:31 UTC
Created attachment 24407 [details] [review]
Bug 11561: Preventing duplicate print notices and enforcing a print notice if no notices can be generated

-------------------------
- REPLICATING THE ISSUE -
-------------------------

1. Set a Patrons "Hold filled"-messaging preference to SMS + Email
2. Remove the SMS number (sms notification number) and all email addresses.
3. Make a reservation for this Patron.
4. Check-in the reserved Item.
5. message_queue-table has two generated print notices for the Hold_filled event.
   One for both failed message transport types, email and sms.

1. Set a Patrons "Hold filled"-messaging preference to empty, remove all checks from boxes.
2. Make a reservation for this Patron
3. Check-in the reserved Item.
4. message_queue-table has no message for the Hold-filled event. This is problematic
   because a Patron should get somekind of a notification for a filled Hold.

-----------------------------
- AFTER APPLYING THIS PATCH -
-----------------------------

If all message transport types for "Hold filled" fail, a print notice is queued
in the message_queue-table. Only one print message is queued even if many transports
attempts fail.
Comment 2 Olli-Antti Kivilahti 2014-01-15 15:10:54 UTC
Apparently not everyone uses print notifications. Maybe a syspref should be added to control the behaviour?
Comment 3 Galen Charlton 2014-05-02 19:08:41 UTC
(In reply to Olli-Antti Kivilahti from comment #2)
> Apparently not everyone uses print notifications. Maybe a syspref should be
> added to control the behaviour?

Indeed, there should be a setting to control whether libraries want to default to printed hold notices.  Folks can feel free to open a new bug report if they want to, but I'll be pushing this patch to master along with the rest of MTT because it  restores previous behavior in this respect.
Comment 4 Galen Charlton 2014-05-02 21:20:50 UTC
Pushed to master.  Thanks, Olli!