| Summary: | Untranslatable subscription frequency units | ||
|---|---|---|---|
| Product: | Koha | Reporter: | paxed <pasi.kallinen> |
| Component: | I18N/L10N | Assignee: | paxed <pasi.kallinen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | f.demians, gmcharlt, jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 11588 - Untranslatable subscription frequency units
Allow translating the subscription frequency units in the template Bug 11588: Untranslatable subscription frequency units [PASSED QA] Bug 11588: Untranslatable subscription frequency units |
||
Created attachment 24892 [details] [review] Bug 11588 - Untranslatable subscription frequency units The subscription add form has a couple of translation issues which are addressed in this patch: First, the frequency option which pulls descriptive strings from the subscription_frequencies table. Second, the subscription length option which is based on hard-coded choices in subscription-add.pl. This patch makes these choices translatable by using a SWITCH in the template based on the predefined strings which can be expected. To test, apply the patch and update the translation of your choice by running 'translate update [language code]'. Confirm that the frequency and length strings are now present in the updated po file. Comment on attachment 24892 [details] [review] Bug 11588 - Untranslatable subscription frequency units Never mind, this method won't work with translated values in the database. Created attachment 27523 [details] [review] Allow translating the subscription frequency units in the template Allow translating the subscription frequency units. To test, 1) cd misc/translator 2) perl translate update xx-YY 3) check that there's no msgid that contains the subscription frequencies (day, week, month and year) in po/xx-YY-i-staff-t-prog-v-3006000.po (search for "BLOCK translate_frequnit") 4) apply patch 5) perl translate update xx-YY 6 check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains the msgid for the frequencies. (search for "BLOCK translate_frequnit") Created attachment 27545 [details] [review] Bug 11588: Untranslatable subscription frequency units Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 27630 [details] [review] [PASSED QA] Bug 11588: Untranslatable subscription frequency units Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. Thanks, Pasi! |
When eg. editing or creating a new subscription frequency, a drop-down lists the possible units for the frequency. These are not translatable, as they're hard-coded eg. in GetFictiveIssueNumber() in C4/Serials.pm ('day', 'week', 'month', 'year')