Bug 11593

Summary: subtag_registry.sql files contain the same information for each language
Product: Koha Reporter: paxed <pasi.kallinen>
Component: I18N/L10NAssignee: Bernardo Gonzalez Kriegel <bgkriegel>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: bgkriegel, f.demians, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Medium patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 11593 - subtag_registry.sql files contain the same information for each language
Bug 11593 - subtag_registry.sql files contain the same information for each language
[PASSED QA] Bug 11593 - subtag_registry.sql files contain the same information for each language
Bug 11593: Remove subtag_registry.txt

Description paxed 2014-01-22 07:05:27 UTC
For each language in the installation, there's a mandatory subtag_registry.sql -file, that contains the language names. Each of those files contain the same language information. This is unnecessary duplication, and makes adding new install languages harder, because the same information needs to be added to each of those files.
Comment 1 Bernardo Gonzalez Kriegel 2014-04-02 21:37:45 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-10-27 06:03:04 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-27 20:10:02 UTC
Created attachment 32806 [details] [review]
[PASSED QA] Bug 11593 - subtag_registry.sql files contain the same information for each language

This patch removes subtag_registry.sql from lang dirs,
and put it on a new mandatory dir

In that way we need to update only one file.
All similar files are removed.

To test:
1) Try a new install, or simply create a new database,
grant permissions on it, change koha-conf.xml to use
this database and go to staff page

2) Go step by step until all mandatory or optional sql
files are loaded. Check that subtag_registry.sql is
loaded.

3) Do it again but on other language. First install
translation and repeat 2), could use de-DE or fr-FR

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, tested with de-DE.
Thx!
Comment 4 Katrin Fischer 2014-10-27 20:10:32 UTC
Created attachment 32807 [details] [review]
Bug 11593: Remove subtag_registry.txt

This file is no longer needed by the web installer and can be deleted.
Comment 5 Katrin Fischer 2014-10-27 20:11:25 UTC
Bernardo, what do you think about removing the text file (see second patch)?
Comment 6 Tomás Cohen Arazi (tcohen) 2014-10-28 13:54:22 UTC
Patch pushed to master.

Thanks Bernardo!
Comment 7 Bernardo Gonzalez Kriegel 2014-10-28 14:45:04 UTC
(In reply to Katrin Fischer from comment #5)
> Bernardo, what do you think about removing the text file (see second patch)?

It's only a description, could be removed... and it's already done :)

I will rework Bug 12250 and complete missing language descriptions
Comment 8 Katrin Fischer 2014-10-28 15:07:25 UTC
Tomas was fast :) Hope you don't mind!