Summary: | Fix localcover display | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicholas van Oudtshoorn <vanoudt> |
Component: | OPAC | Assignee: | Nicholas van Oudtshoorn <vanoudt> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, f.demians, hector.hecaxmmx, julian.maurice, kyle, liz |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
Adds a CSS class of thumbnail to local covers. Don't show the 1px "No image found" image (since we'll usually try another image provider).
|
Version(s) released in: | |
Circulation function: | |||
Attachments: |
Add a class to local thumbnails and don't show 1px no-image-found
[SIGNED-OFF]BUG 11602: [ENH] Fix localcover display Adds a css class of thumbnail to local covers [PASSED QA] BUG 11602: [ENH] Fix localcover display |
Description
Nicholas van Oudtshoorn
2014-01-23 05:26:12 UTC
Created attachment 28270 [details] [review] Add a class to local thumbnails and don't show 1px no-image-found Created attachment 45347 [details] [review] [SIGNED-OFF]BUG 11602: [ENH] Fix localcover display Adds a css class of thumbnail to local covers Don't show the 1px "No image found" image (since we'll ususally try another image provider) Add a class to local thumbnails and don't show 1px no-image-found Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Box with "No cover image availabe" fixed when syspref OPACLocalCoverImages set to display Created attachment 45364 [details] [review] [PASSED QA] BUG 11602: [ENH] Fix localcover display Adds a css class of thumbnail to local covers. Don't show the 1px "No image found" image (since we'll ususally try another image provider) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Box with "No cover image availabe" fixed when syspref OPACLocalCoverImages set to display Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I see 2 sides on this: - It makes local covers behave more like the other cover services, showing the standard 'no-image'. (consistency) - It means a change to existing installations, but the newly showing image can be easily hidden with CSS... so not sure this should stop this. Patch pushed to master. Thanks Nicholas! Patch pushed to 3.22.x, will be in 3.22.1 This patch has been pushed to 3.20.x, will be in 3.20.7. Thanks everyone - great to have contributed to Koha! :-) |