Summary: | items.content does not contain any formatting when HTML message is selected. | ||
---|---|---|---|
Product: | Koha | Reporter: | Barton Chittenden <bartonski> |
Component: | Notices | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | derrynj, jonathan.druart, ruatuki, sophie.meynieux, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 11607: Don't display all items in a single line
Bug 11607: Don't display all items in a single line [PASSED QA] Bug 11607: Don't display all items in a single line |
Description
Barton Chittenden
2014-01-24 14:24:36 UTC
I was just about to file a bug for this when I saw you had already done so. Just in case anyone needs clarification: To reproduce 1. Tools -> Notices 2. Edit 'Item Due Reminder (Digest)' 3. Tick 'HTML message' 4. Enter <<items.content>> in the message body. 5. Save 6. Borrow 2 items on an account set up to receive item due email notifications and set the due date as today. 7. Run advance_notices.pl 8. Run process_message_queue.pl 9. Check your email - there will be 2 items on one line, rather than a line break between them. If you repeat the above steps without checking 'HTML message' it does include line breaks. This issue is still present in 3.16 Created attachment 34677 [details] [review] Bug 11607: Don't display all items in a single line If the *DGST notices are sent in HTML, the items are displayed in a single line. To reproduce: 1/ Define a *DGST notice using the <<items.content>> pattern. 2/ Checkout at least 2 items to a patron and set the due date as today. 3/ Launch the advance_notices.pl and process_message_queue.pl cronjobs. 4/ Verify the email you will receive separates the items with a line break. Verify you don't find a regression for non-html letters. Created attachment 34688 [details] [review] Bug 11607: Don't display all items in a single line If the *DGST notices are sent in HTML, the items are displayed in a single line. To reproduce: 1/ Define a *DGST notice using the <<items.content>> pattern. 2/ Checkout at least 2 items to a patron and set the due date as today. 3/ Launch the advance_notices.pl and process_message_queue.pl cronjobs. 4/ Verify the email you will receive separates the items with a line break. Verify you don't find a regression for non-html letters. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 34700 [details] [review] [PASSED QA] Bug 11607: Don't display all items in a single line If the *DGST notices are sent in HTML, the items are displayed in a single line. To reproduce: 1/ Define a *DGST notice using the <<items.content>> pattern. 2/ Checkout at least 2 items to a patron and set the due date as today. 3/ Launch the advance_notices.pl and process_message_queue.pl cronjobs. 4/ Verify the email you will receive separates the items with a line break. Verify you don't find a regression for non-html letters. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Note: the display in the notices tab is misleading here, needs to be verified checking the sent emails or database entries in message_queue. Patch pushed to master. Thanks Jonathan! |