Summary: | don't need the word 'library' on funds | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Nicole C. Engard <nengard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/acqui/acqui-home.pl | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Library 2 times
[Bug 11608] Remove the word 'library' from funds list Bug 11608: Remove the word 'library' from funds list Bug 11608: Remove the word 'library' from funds list Bug 11608: Delete unused commented lines in template [PASSED QA] Bug 11608: Remove the word 'library' from funds list [PASSED QA] Bug 11608: Delete unused commented lines in template |
Description
Nicole C. Engard
2014-01-24 14:29:28 UTC
Created attachment 24694 [details]
Library 2 times
Created attachment 24695 [details] [review] [Bug 11608] Remove the word 'library' from funds list The list of funds on the main acq page shows the library's name followed by the word 'library'. I don't think this word is necessary as most libraries have the word 'library' in their names. Even if they don't they probably just want their library name to show without extra words. To test: * Visit the acquisitions module before applying * See the library's name + 'library' above the funds list * Apply patch * Look again at funds list and 'library' should be gone Created attachment 24700 [details] [review] Bug 11608: Remove the word 'library' from funds list The list of funds on the main acq page shows the library's name followed by the word 'library'. I don't think this word is necessary as most libraries have the word 'library' in their names. Even if they don't they probably just want their library name to show without extra words. To test: * Visit the acquisitions module before applying * See the library's name + 'library' above the funds list * Apply patch * Look again at funds list and 'library' should be gone Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 24701 [details] [review] Bug 11608: Remove the word 'library' from funds list The list of funds on the main acq page shows the library's name followed by the word 'library'. I don't think this word is necessary as most libraries have the word 'library' in their names. Even if they don't they probably just want their library name to show without extra words. To test: * Visit the acquisitions module before applying * See the library's name + 'library' above the funds list * Apply patch * Look again at funds list and 'library' should be gone Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: remove a space Created attachment 24702 [details] [review] Bug 11608: Delete unused commented lines in template On the way, these lines are commented and can be deleted safely. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 24727 [details] [review] [PASSED QA] Bug 11608: Remove the word 'library' from funds list The list of funds on the main acq page shows the library's name followed by the word 'library'. I don't think this word is necessary as most libraries have the word 'library' in their names. Even if they don't they probably just want their library name to show without extra words. To test: * Visit the acquisitions module before applying * See the library's name + 'library' above the funds list * Apply patch * Look again at funds list and 'library' should be gone Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: remove a space Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. Created attachment 24728 [details] [review] [PASSED QA] Bug 11608: Delete unused commented lines in template On the way, these lines are commented and can be deleted safely. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Removes an HTML comment with unused code. Pushed to master. Thanks, Nicole! Pushed to 3.14.x, will be in 3.14.07 Pushed to 3.12.x will be in 3.12.13 |