Summary: | Remove sorting from patron lists action columns | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | boutrosboutrosboutros, fridolin.somers, gmcharlt |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 11670 - Remove sorting from patron lists action columns
Bug 11670 - Remove sorting from patron lists action columns Bug 11670 - Remove sorting from patron lists action columns |
Description
Owen Leonard
2014-02-03 16:57:27 UTC
Created attachment 25009 [details] [review] Bug 11670 - Remove sorting from patron lists action columns The list of patron lists has sortable columns for the add, edit, and delete buttons. These columns should not be sortable. This patch removes sorting. This patch also adds the "btn-mini" class to the in-table buttons to make the table more compact. To test you must have existing patron lists. Apply the patch and navigate to Tools -> Patron lists. The columns containing the add, edit, and delete buttons should not be sortable. Other columns should sort correctly. Created attachment 25050 [details] [review] Bug 11670 - Remove sorting from patron lists action columns The list of patron lists has sortable columns for the add, edit, and delete buttons. These columns should not be sortable. This patch removes sorting. This patch also adds the "btn-mini" class to the in-table buttons to make the table more compact. To test you must have existing patron lists. Apply the patch and navigate to Tools -> Patron lists. The columns containing the add, edit, and delete buttons should not be sortable. Other columns should sort correctly. --------------------------------------------------------------------- Created to patron lists and confirmed the collums 'add patrons', 'edit' and 'delete' are no longer sortable. Column 'Name' and 'Patrons in list' are still sortable. The size of buttons are smaller. I also agree this is an improvement. Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com> Sorry, a few typos there, should be Created TWO patron lists and confirmed the COLUMNS ... Created attachment 25136 [details] [review] Bug 11670 - Remove sorting from patron lists action columns The list of patron lists has sortable columns for the add, edit, and delete buttons. These columns should not be sortable. This patch removes sorting. This patch also adds the "btn-mini" class to the in-table buttons to make the table more compact. To test you must have existing patron lists. Apply the patch and navigate to Tools -> Patron lists. The columns containing the add, edit, and delete buttons should not be sortable. Other columns should sort correctly. --------------------------------------------------------------------- Created to patron lists and confirmed the collums 'add patrons', 'edit' and 'delete' are no longer sortable. Column 'Name' and 'Patrons in list' are still sortable. The size of buttons are smaller. I also agree this is an improvement. Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master. Thanks, Owen! Pushed to 3.14.x, will be in 3.14.07. |